Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Apr 2022 19:13:51 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Adriaan de Groot <adridg@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, "Tobias C. Berner" <tcberner@freebsd.org>
Subject:   Re: git: aa2539679084 - main - framework: cleanup conditional-indentations in Mk/
Message-ID:  <YmWhbwhJSbYCcLAt@FreeBSD.org>
In-Reply-To: <7805992.iDzAj6rjnq@beastie.bionicmutton.org>
References:  <202204241007.23OA70ca039751@gitrepo.freebsd.org> <7805992.iDzAj6rjnq@beastie.bionicmutton.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 24, 2022 at 07:51:33PM +0200, Adriaan de Groot wrote:
> On Sunday, 24 April 2022 12:07:00 CEST Tobias C. Berner wrote:
> > The branch main has been updated by tcberner:
> > 
> > commit aa2539679084872cd84112e9df6bfee571570623
> > 
> >     framework: cleanup conditional-indentations in Mk/
> > 
> >     These white space changes contribute greatly to the readability of those
> > files. As we have a version control system, finding out the reasons for the
> > changes prior to these white space changes is still easily possible
> 
> This is a nice moment to point at "git blame" -- which will tell you when a
> line was last changed, and by whom. Naive use of "git blame" will now point a
> lot of lines at tcberner@, even though it was just whitespace. You can tell
> "git blame" to ignore certain revisions, and so discover the original authors
> before the white-space changes.

Or one can just ask for `git blame' just before that revision:

$ git blame aa25396790848^ Mk/bsd.sites.mk # (notice the caret)

> Actually, "blame" is kind of an unfriendly name. We should be cheering for
> the people who create the software we use daily!

Sadly, most of the times I have to issue `git blame' is not to cheer about
a particular change, but, really, blame.  FWIW, Subversion has `svn praise'
which is an alias for `svn blame'.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YmWhbwhJSbYCcLAt>