From owner-cvs-all@FreeBSD.ORG  Wed Sep 13 23:32:11 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A56E216A40F;
	Wed, 13 Sep 2006 23:32:11 +0000 (UTC)
	(envelope-from flata@magnesium.net)
Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 73DE143D45;
	Wed, 13 Sep 2006 23:32:11 +0000 (GMT)
	(envelope-from flata@magnesium.net)
Received: by toxic.magnesium.net (Postfix, from userid 1212)
	id 3AA8BDA89D; Wed, 13 Sep 2006 16:32:11 -0700 (PDT)
Date: Wed, 13 Sep 2006 13:32:11 -1000
From: Juli Mallett <jmallett@FreeBSD.org>
To: "David E. O'Brien" <obrien@FreeBSD.org>
Message-ID: <20060913233211.GA83839@toxic.magnesium.net>
References: <200609132327.k8DNRMqS076204@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200609132327.k8DNRMqS076204@repoman.freebsd.org>
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Sep 2006 23:32:11 -0000

Hi David,

* "David E. O'Brien" <obrien@FreeBSD.org> [ 2006-09-13 ]
	[ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ]
>   When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as its easy
>   to see "warning: unused variable `foo'".

I think it might be a better idea to -Wno-unused, since the only sorts of
warnings one wants to ignore building NDEBUG are the variables which are
otherwise unused.  For example, if someone does something like:

	int foo;

	assert((foo = some_function()) != 0);
	printf("got foo=%d\n", foo);

We *really* want to have that warning be an error, as foo is being used
uninitialized, and the code is broken.

Thanx,
juli.