From owner-p4-projects@FreeBSD.ORG  Mon Jul  7 08:43:18 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C09421065684; Mon,  7 Jul 2008 08:43:18 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8315E106567B;
	Mon,  7 Jul 2008 08:43:18 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from watery.cc.kogakuin.ac.jp (watery.cc.kogakuin.ac.jp
	[133.80.152.80])
	by mx1.freebsd.org (Postfix) with ESMTP id 37D9E8FC1B;
	Mon,  7 Jul 2008 08:43:18 +0000 (UTC)
	(envelope-from nyan@jp.FreeBSD.org)
Received: from localhost (localhost [IPv6:::1])
	by watery.cc.kogakuin.ac.jp (unknown) with ESMTP id m678hGNq023524;
	Mon, 7 Jul 2008 17:43:16 +0900 (JST)
	(envelope-from nyan@jp.FreeBSD.org)
Date: Mon, 07 Jul 2008 17:42:08 +0900 (JST)
Message-Id: <20080707.174208.94913728.nyan@jp.FreeBSD.org>
To: xcllnt@mac.com
From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>
In-Reply-To: <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com>
References: <200807051943.m65JhHZ6066371@repoman.freebsd.org>
	<20080706.110943.226722229.nyan@jp.FreeBSD.org>
	<EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com>
X-Mailer: Mew version 6.1 on Emacs 22.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: marcel@freebsd.org, perforce@freebsd.org
Subject: Re: PERFORCE change 144741 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jul 2008 08:43:19 -0000

In article <EF89C58B-6C77-4738-8A77-44BD3B655ED5@mac.com>
Marcel Moolenaar <xcllnt@mac.com> writes:

> > These are wrong.  RSA98-III is based on ns8250 and has extended FIFO
> > buffer.  So I think that the uart_rsa_class should be added.
> 
> Oh. In your patch you define it as i8251. I only refactored
> the code. Also, the ns8250 class already supports extended
> FIFOs, so we don't need a separate class for that. I'll
> change it...

No.  My code set sc_class to uart_rsa_class.  It's your mistake.

And then I found another problem in uart_bus_isa.c.  In your code
non-PnP devices for pc98 cannot probe.  My original code was no
problem...

And, RSA has extra registers to control its FIFO buffer.  So we need
additional code to support it.
See: sys/dev/ic/rsa.h and sys/pc98/cbus/sio.c

---
TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>