From owner-freebsd-questions Mon Apr 29 08:21:53 1996 Return-Path: owner-questions Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id IAA22778 for questions-outgoing; Mon, 29 Apr 1996 08:21:53 -0700 (PDT) Received: from rocky.sri.MT.net (rocky.sri.MT.net [204.182.243.10]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id IAA22771 for ; Mon, 29 Apr 1996 08:21:47 -0700 (PDT) Received: (from nate@localhost) by rocky.sri.MT.net (8.6.12/8.6.12) id JAA27570; Mon, 29 Apr 1996 09:19:51 -0600 Date: Mon, 29 Apr 1996 09:19:51 -0600 From: Nate Williams Message-Id: <199604291519.JAA27570@rocky.sri.MT.net> To: smarq@ucthpx.uct.ac.za (S Marquard) Cc: freebsd-questions@freebsd.org Subject: Re: PPPD doesn't die cleanly in 2.1-R (bug?) In-Reply-To: References: Sender: owner-questions@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > In the pppd (kernel PPP) in 2.1-RELEASE, if a pppd process dies > on a read error, the cleanup procedures are never called. Actually, 'die()' is the generic cleanup process. ... > I fixed this problem by the following patch to > /usr/src/usr.sbin/pppd/sys-bsd.c: > > *** sys-bsd.c.OLD Mon Feb 26 22:11:17 1996 > --- sys-bsd.c Mon Apr 29 10:13:09 1996 > *************** > *** 168,173 **** > --- 168,174 ---- > return -1; > } > syslog(LOG_ERR, "read(fd): %m"); > + lcp_lowerdown(0); /* die cleanly */ Would it be better to add lcp_lowerdown() to die(), which would fix any occurance of PPPD dying abnormally and not cleaning things up correctly? (I didn't look at this too closely, but it seems to be a better 'generic' fix for the problem.) If you could add the code to die() and test it I would certainly be willing to commit it. Nate