From owner-svn-src-all@FreeBSD.ORG Tue Mar 3 00:55:39 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7ECDFBE2; Tue, 3 Mar 2015 00:55:39 +0000 (UTC) Received: from mail-we0-x232.google.com (mail-we0-x232.google.com [IPv6:2a00:1450:400c:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22CBA31A; Tue, 3 Mar 2015 00:55:39 +0000 (UTC) Received: by wevm14 with SMTP id m14so36733510wev.13; Mon, 02 Mar 2015 16:55:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=eVfG1bomC++IAiBBgS39sgQhg3iFXL6vkz9CUFE06uo=; b=Bzn10kAA6mW2sg3VurXboFvLoroPEZdt/zK4fvUaD+6AziBrWOgBlje1ZT+xE8wFrR uGXSXjcnKVXfX5+Ca4HJqzhUiKyRpoT116699r17UAofKV2lZ1E1btpbLpnFelPSu+E3 GTHerY05TycM9M8YMcXCJ4x+ayBc7DdZyILNbxznUqwYbvM2nP74/dlSf/fWyi3rlVLF gAla5SJRt0zmYDf/uTzMr503jV6A0ogOX91D+OR00T5EX/7q7p1O6g999lAtvTGn6Xlk ehkdNT019zR2P3CnrJ+UhDo2lWa7MLDuIxpd+T5DG5rOv4IYr45u0vTpUNPOcs7mH9UZ MYRA== MIME-Version: 1.0 X-Received: by 10.194.94.1 with SMTP id cy1mr62327157wjb.127.1425344137633; Mon, 02 Mar 2015 16:55:37 -0800 (PST) Received: by 10.27.91.79 with HTTP; Mon, 2 Mar 2015 16:55:37 -0800 (PST) In-Reply-To: References: <201503022005.t22K5HTL062907@svn.freebsd.org> Date: Mon, 2 Mar 2015 16:55:37 -0800 Message-ID: Subject: Re: svn commit: r279539 - head/sys/sys From: Neel Natu To: Davide Italiano Content-Type: text/plain; charset=UTF-8 Cc: John-Mark Gurney , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2015 00:55:39 -0000 Hi Davide, On Mon, Mar 2, 2015 at 12:26 PM, Davide Italiano wrote: > On Mon, Mar 2, 2015 at 12:05 PM, John-Mark Gurney wrote: >> Author: jmg >> Date: Mon Mar 2 20:05:16 2015 >> New Revision: 279539 >> URL: https://svnweb.freebsd.org/changeset/base/279539 >> >> Log: >> give others fair warning that _SPARE2 isn't just cxgb, but used by large >> number of other subsystems, so you probably don't want _SPARE2.. >> >> ktr needs an overhaul to really only compile in the ones you want, >> we've long passed the 31 bits it provides.. >> > > If you really want to do the overhaul (which would be honestly great), > I might consider revamping my work for per-cpu KTR buffer and include > that in the change. Originally it was just an exercise, but then it > evolved and I've been sitting with it in my local tree for a while. I > never had the chutzpah to upstream it because it involves fundamental > changes and breaks compatibility with the old ktrdump(1) format. > A rather outdated (and maybe not completely functional) version of the > patch can be found here: > http://people.freebsd.org/~davide/locking/ktr_percpu.4.diff , which > should give you an high level view of the change. > I can update it to the last version and bring up for review, if > somebody think it might be a sane idea avoiding synchronization on a > single buffer for KTR. > This would be a very welcome improvement. best Neel > -- > Davide >