From owner-svn-src-all@freebsd.org Wed Jun 27 23:52:24 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B5C63101EB06; Wed, 27 Jun 2018 23:52:24 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [198.45.61.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3A1707AD46; Wed, 27 Jun 2018 23:52:24 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w5RNqGsr031866 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 27 Jun 2018 16:52:16 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id w5RNqGbc031865; Wed, 27 Jun 2018 16:52:16 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Wed, 27 Jun 2018 16:52:16 -0700 From: Gleb Smirnoff To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335690 - head/sys/kern Message-ID: <20180627235216.GO1165@FreeBSD.org> References: <201806270411.w5R4B9ZB078994@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201806270411.w5R4B9ZB078994@repo.freebsd.org> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 23:52:24 -0000 On Wed, Jun 27, 2018 at 04:11:09AM +0000, Warner Losh wrote: W> Author: imp W> Date: Wed Jun 27 04:11:09 2018 W> New Revision: 335690 W> URL: https://svnweb.freebsd.org/changeset/base/335690 W> W> Log: W> Fix devctl generation for core files. W> W> We have a problem with vn_fullpath_global when the file exists. Work W> around it by printing the full path if the core file name starts with /, W> or current working directory followed by the filename if not. Is this going to work when a core is dumped not at current working directory, but at absolute path? e.g. kern.corefile=/var/log/cores/%N.core Looks like the vn_fullpath_global needs to be fixed rather than problem workarounded. -- Gleb Smirnoff