From owner-svn-ports-all@freebsd.org Tue Jul 16 18:27:58 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3F94EB71A7; Tue, 16 Jul 2019 18:27:58 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2254E6DFCC; Tue, 16 Jul 2019 18:27:58 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id EFA1D1A524; Tue, 16 Jul 2019 18:27:57 +0000 (UTC) From: Jan Beich To: Steve Wills Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r506329 - head/multimedia/libva References: <201907100116.x6A1GDuA002773@repo.freebsd.org> <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org> Date: Tue, 16 Jul 2019 20:27:51 +0200 In-Reply-To: <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org> (Steve Wills's message of "Tue, 16 Jul 2019 14:09:41 -0400") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 2254E6DFCC X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.88 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_SHORT(-0.91)[-0.913,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_MEDIUM(-0.97)[-0.972,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 18:27:58 -0000 Steve Wills writes: > Hi, > On 7/9/19 9:16 PM, Jan Beich wrote: > >> Author: jbeich >> Date: Wed Jul 10 01:16:13 2019 >> New Revision: 506329 >> URL: https://svnweb.freebsd.org/changeset/ports/506329 >> >> Log: >> multimedia/libva: drop -lpthread on FreeBSD 11.4/12.1/13.0 >> libva doesn't use threads unless LIBVA_TRACE is passed via >> environment. >> PR: 238650 >> >> Modified: >> head/multimedia/libva/Makefile (contents, props changed) >> >> Modified: head/multimedia/libva/Makefile >> ============================================================================== >> --- head/multimedia/libva/Makefile Wed Jul 10 01:16:04 2019 (r506328) >> +++ head/multimedia/libva/Makefile Wed Jul 10 01:16:13 2019 (r506329) >> @@ -19,7 +19,11 @@ USES= meson pkgconfig >> USE_GITHUB= yes >> USE_LDCONFIG= yes >> GH_ACCOUNT= intel >> -LDFLAGS+= -lpthread # for pthread_getthreadid_np >> +# -lpthread is not necessary if pthread_getthreadid_np is a libc stub >> +LDFLAGS+= ${LDFLAGS_${OPSYS}_${OSREL}} >> +LDFLAGS_FreeBSD_11.2= -lpthread >> +LDFLAGS_FreeBSD_11.3= -lpthread >> +LDFLAGS_FreeBSD_12.0= -lpthread >> OPTIONS_DEFINE= GLX WAYLAND X11 >> OPTIONS_DEFAULT=GLX WAYLAND X11 >> > > This broke the build for me, running CURRENT r348454 in my jail. Do I > need to update my jail? Yep. Old -CURRENT/-STABLE snapshots were never supported[1]. Bug 238650 references commits for each branch. [1] in terms of security fixes, binary packages and, by extension, building from source