Date: Tue, 16 Jul 2019 20:27:51 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r506329 - head/multimedia/libva Message-ID: <ims1-bzrs-wny@FreeBSD.org> In-Reply-To: <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org> (Steve Wills's message of "Tue, 16 Jul 2019 14:09:41 -0400") References: <201907100116.x6A1GDuA002773@repo.freebsd.org> <554d91d4-b243-a73b-9761-57c7da31a8ce@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Steve Wills <swills@FreeBSD.org> writes: > Hi, > On 7/9/19 9:16 PM, Jan Beich wrote: > >> Author: jbeich >> Date: Wed Jul 10 01:16:13 2019 >> New Revision: 506329 >> URL: https://svnweb.freebsd.org/changeset/ports/506329 >> >> Log: >> multimedia/libva: drop -lpthread on FreeBSD 11.4/12.1/13.0 >> libva doesn't use threads unless LIBVA_TRACE is passed via >> environment. >> PR: 238650 >> >> Modified: >> head/multimedia/libva/Makefile (contents, props changed) >> >> Modified: head/multimedia/libva/Makefile >> ============================================================================== >> --- head/multimedia/libva/Makefile Wed Jul 10 01:16:04 2019 (r506328) >> +++ head/multimedia/libva/Makefile Wed Jul 10 01:16:13 2019 (r506329) >> @@ -19,7 +19,11 @@ USES= meson pkgconfig >> USE_GITHUB= yes >> USE_LDCONFIG= yes >> GH_ACCOUNT= intel >> -LDFLAGS+= -lpthread # for pthread_getthreadid_np >> +# -lpthread is not necessary if pthread_getthreadid_np is a libc stub >> +LDFLAGS+= ${LDFLAGS_${OPSYS}_${OSREL}} >> +LDFLAGS_FreeBSD_11.2= -lpthread >> +LDFLAGS_FreeBSD_11.3= -lpthread >> +LDFLAGS_FreeBSD_12.0= -lpthread >> OPTIONS_DEFINE= GLX WAYLAND X11 >> OPTIONS_DEFAULT=GLX WAYLAND X11 >> > > This broke the build for me, running CURRENT r348454 in my jail. Do I > need to update my jail? Yep. Old -CURRENT/-STABLE snapshots were never supported[1]. Bug 238650 references commits for each branch. [1] in terms of security fixes, binary packages and, by extension, building from source
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ims1-bzrs-wny>