From nobody Wed Jul 2 19:35:38 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bXVVg10wwz60qHs for ; Wed, 02 Jul 2025 19:35:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bXVVf4HtHz3ctB for ; Wed, 02 Jul 2025 19:35:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751484938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stvlMG338//BMilvPbvevtt1ZIqtDrAAcYSRDpfHrnA=; b=K+1SZcKIMqVh1/bThPbt4182NVc81awuLuA7cE5gQAeekLyjbsNZIKfZPJgruuQY0VztBY tdYVLfd9ulUiJVc9Cs84cNEB6SN1O5qPw0peLNTl9cJvuebv7nB+jz32U5UvfWhbC9hvIl 2xshpRwanIDBu1TzE5IAtvrNx3aXD2diua+JIFUs7Jqczac/JmwqfTDDGoaxPf5XYmSa/u ev6iNb0AE/oz8olkG+xXGOMFkFE7vHDcHTq3/yB6kk+tRgDGvVvqDrBUvI3QZWXlXrTK+E W4SxgjcjvV1kCzs9rWNA4j806WT12Dcom5LJZZRW3Ch2YA97BVNIwIpBZVzD4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751484938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=stvlMG338//BMilvPbvevtt1ZIqtDrAAcYSRDpfHrnA=; b=KA8twwvkSgXvRvwAU79Si68b3FxoiE+zjnRDsOmICkoATtj6BnviSUJErbDJxAtTs68qsk X23ZCDYw/aT1Id1LwJE+Y2HOEeGYww6p4Axo7YhzcClwYjxcpnRrzhvCSe5x0URDMs+MUn 3rnvBz57/4D/IWVrIRiGuSrP3B9+srXPnRz67xftRB7eTj3kC2781b7pb0NyUb0vHS34UD NOTOZX5qTb+J5zFbYBS2DqrG5/Q2OsRzImNwAcTcgHZ2KyH0NF0ytls2H3AWVAM/rYev9F jKH0nBvOQmTApKJfcM75R2Vyx/fSJtI4ghA+txqneFxLrnozqV6LpyZP0OS4Rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751484938; a=rsa-sha256; cv=none; b=KWnWrGHu/JADQP6b7Xe2Do5C9odS30ZzEsYrcJQfJmClCzwivYx81hGVDz19U7etWmCS+J NyJs4WyZ3Q0TDF1JWNmHNwF7S1M2KJhnkbcnUlev5CCbIifJKxacsCxJ7W/lSS6SvEW+Uh QIyqEL18f3vyfEjCY/mDICzZRyFrQzY2iJQfYSDt0gCdDWQ9LBlinraoHMOX22MMK87CEo qFGbPN4UvA12RdLUaZAA6rcdajQLy2i294V5tTY6/ehigtCsIvDLpsRZ2Ls1VrNASUPtMk TqFPYVf85S85zc4dro3HCSdTZUaDMQF2e4bJEr8jeVKILa5Mlk4rMlDxINzyCQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bXVVf2YKCzYCZ for ; Wed, 02 Jul 2025 19:35:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 562JZcdf091326 for ; Wed, 2 Jul 2025 19:35:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 562JZcRg091325 for net@FreeBSD.org; Wed, 2 Jul 2025 19:35:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 256850] poor mac address distribution for if_tap Date: Wed, 02 Jul 2025 19:35:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256850 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D604d34c23f772ae0005a552b0b7189f3d= c97d519 commit 604d34c23f772ae0005a552b0b7189f3dc97d519 Author: Maxim Shalomikhin AuthorDate: 2025-07-02 19:25:57 +0000 Commit: Kyle Evans CommitDate: 2025-07-02 19:33:52 +0000 net: ether_gen_addr: fix address generation Some errors in ether_gen_addr() caused us to generate MAC addresses out of range, and the ones that were within range had other errors causing the pool of addresses that we might actually generate to shrink. Fix both prblems by using only two bytes of the digest and then OR'ing against the mask, which has the appropriate byte set for the fourth octet of the range already; essentially, our digest is only contributing the last two octets. Change is the author, but any blame for the commit message goes to kevans. PR: 256850 Relnotes: yes sys/net/if_ethersubr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=