From owner-freebsd-hackers@FreeBSD.ORG Wed Aug 8 22:40:57 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3CFC0106564A; Wed, 8 Aug 2012 22:40:57 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id EACF88FC16; Wed, 8 Aug 2012 22:40:56 +0000 (UTC) Received: by obbun3 with SMTP id un3so2352336obb.13 for ; Wed, 08 Aug 2012 15:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=SA8jYT5RjN+GL32oLqZTmNYucduDo7Fve58QLG6VIiI=; b=i31yHpuc98DkN9g0hSsAIF+L83/78uzFcSIlt+fuIqIYLPjuFgHGJTTHsIQByIj5vN bqKUiisKWss5Pl+xrXZ+NKjfL6zCNuUzqgkOSV1/WI0pcg5ZYsr7shGsA4wE3OFKBxFB 7v7kpiVrTd3jIX8IM5SdUhWNT72VDaTUzX12GJF033cegFCfPNdnl84Exez+dGr3Tcs4 tqi+vDWZn5cFJ7r4lRnZqm1++Ot2+e3H8qwd2Coi7N/Zgrwl+LJTidMONZ1t2AfVlJ2R PRQdfZhBpFy9IkGwQcI49UuK67Rz4DDwOlnfT/ws3VGROrJjRHO6Cd1RKFr0zAYzeeZP cYuw== MIME-Version: 1.0 Received: by 10.60.3.194 with SMTP id e2mr32841684oee.1.1344465656253; Wed, 08 Aug 2012 15:40:56 -0700 (PDT) Received: by 10.76.84.7 with HTTP; Wed, 8 Aug 2012 15:40:56 -0700 (PDT) In-Reply-To: References: Date: Wed, 8 Aug 2012 15:40:56 -0700 Message-ID: From: Garrett Cooper To: Dan McGregor Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-hackers@freebsd.org, Gabor Kovesdan Subject: Re: Consistent use of lex flags X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2012 22:40:57 -0000 On Wed, Aug 8, 2012 at 1:59 PM, Dan McGregor wrote: > Hi. > > I was just noticing that mkcsmapper doesn't build with clang. I saw two > ways to do this, the first being to #define YY_NO_INPUT, and the other to > use the %option noinput lex flag. > > While there, I decided to explore and I changed a bunch of #defines to the > standard lex way of doing things. I thought it would be good if all the > code that originated in FreeBSD could be consistent. > > Thoughts? Probably should CC gabor@ next time (done this time) and maybe involve the NetBSD folks as this code is sort of upstreamed from them IIRC. Cheers! -Garrett