From owner-svn-ports-head@FreeBSD.ORG  Tue May  7 05:00:07 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 937F5A38;
 Tue,  7 May 2013 05:00:07 +0000 (UTC)
 (envelope-from olgeni@FreeBSD.org)
Received: from olgeni.olgeni.com (olgeni.olgeni.com [31.171.246.156])
 by mx1.freebsd.org (Postfix) with ESMTP id 59E62EA7;
 Tue,  7 May 2013 05:00:07 +0000 (UTC)
Received: from olgeni.olgeni (dynamic-adsl-94-36-172-31.clienti.tiscali.it
 [94.36.172.31])
 by olgeni.olgeni.com (Postfix) with ESMTPSA id 8D8F9174520;
 Tue,  7 May 2013 06:59:59 +0200 (CEST)
Date: Tue, 7 May 2013 06:59:58 +0200 (CEST)
From: Jimmy Olgeni <olgeni@FreeBSD.org>
X-X-Sender: olgeni@olgeni.olgeni
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r317548 - head/lang/erlang
In-Reply-To: <20130507014034.GB14600@FreeBSD.org>
Message-ID: <alpine.BSF.2.00.1305070656470.5814@olgeni.olgeni>
References: <201305062018.r46KIXbK048584@svn.freebsd.org>
 <20130507014034.GB14600@FreeBSD.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 May 2013 05:00:07 -0000


On Tue, 7 May 2013, Alexey Dokuchaev wrote:

> I don't quite understand this change.  Why move mkdir inside the 
loop?

Very dumb mistake on my part - I saw an "if" rather than a "for" :|

> The port itself could probably benefit from some cleaning and fixing of
> several style bugs.

Probably a good idea. Do you have a quick list of things I should look into?

--
jimmy