From owner-p4-projects@FreeBSD.ORG  Mon Mar  7 10:39:38 2011
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 854AE106578E; Mon,  7 Mar 2011 10:39:38 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4752010657AF
	for <perforce@FreeBSD.org>; Mon,  7 Mar 2011 10:39:38 +0000 (UTC)
	(envelope-from lz@FreeBSD.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 1A4A68FC1A
	for <perforce@FreeBSD.org>; Mon,  7 Mar 2011 10:39:38 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id p27AdbJU057285
	for <perforce@FreeBSD.org>; Mon, 7 Mar 2011 10:39:37 GMT
	(envelope-from lz@FreeBSD.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id p27Adb2k057282
	for perforce@freebsd.org; Mon, 7 Mar 2011 10:39:37 GMT
	(envelope-from lz@FreeBSD.org)
Date: Mon, 7 Mar 2011 10:39:37 GMT
Message-Id: <201103071039.p27Adb2k057282@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	lz@FreeBSD.org using -f
From: Zheng Liu <lz@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 189657 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2011 10:39:38 -0000

http://p4web.freebsd.org/@@189657?ac=10

Change 189657 by lz@freebsd-dev on 2011/03/07 10:38:51

	       Improve sweep loop in ext2_clusteralloc() like in ffs.

Affected files ...

.. //depot/projects/soc2010/extfs/src/sys/fs/ext2fs/ext2_alloc.c#36 edit

Differences ...

==== //depot/projects/soc2010/extfs/src/sys/fs/ext2fs/ext2_alloc.c#36 (text+ko) ====

@@ -1309,16 +1309,13 @@
         int error, i, got, run;
         char *bbp;
         daddr_t bno;
+        int bit, map;
+        unsigned char *mapp;
 
         fs = ip->i_e2fs;
         ump = ip->i_ump;
 
-        /*
-         * TODO: we need to define a new member in m_ext2fs structure
-         * to save max cluster. But for simplicity, we assume that the
-         * max cluster is equal to the number of blocks per group.
-         */
-        if (fs->e2fs_gd[cg].ext2bgd_nbfree < len)
+        if (fs->e2fs_maxcluster[cg] < len)
                 return (0);
 
         EXT2_UNLOCK(ump);
@@ -1340,25 +1337,35 @@
                 bpref = 0;
         if (bpref != 0)
                 bpref = dtogd(fs, bpref);
-
+        mapp = &bbp[bpref / NBBY];
+        map = *mapp++;
+        bit = 1 << (bpref % NBBY);
         for (run = 0, got = bpref; got < fs->e2fs_bpg; got++) {
-                if (!isclr(bbp, got))
+                if (!((map & bit) == 0)) {
                         run = 0;
-                else {
+                } else {
                         run++;
                         if (run == len)
                                 break;
                 }
+                if ((got & (NBBY - 1)) != (NBBY - 1)) {
+                        bit <<= 1;
+                } else {
+                        map = *mapp++;
+                        bit = 1;
+                }
         }
 
         if (got >= fs->e2fs_bpg)
                 goto fail_lock;
+
         /*
          * Allocate the cluster that we have found.
          */
         for (i = 1; i <= len; i++)
                 if (!isclr(bbp, got - run + i))
                         panic("ext2_clusteralloc: map mismatch");
+                
         bno = got - run + 1;
         if (bno >= fs->e2fs_bpg)
                 panic("ext2_clusteralloc: allocated out of group");