From owner-freebsd-arch@FreeBSD.ORG Thu Dec 11 19:57:47 2008 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66012106564A for ; Thu, 11 Dec 2008 19:57:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.terabit.net.ua (mail.terabit.net.ua [195.137.202.147]) by mx1.freebsd.org (Postfix) with ESMTP id 0F1F58FC16 for ; Thu, 11 Dec 2008 19:57:46 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from skuns.zoral.com.ua ([91.193.166.194] helo=mail.zoral.com.ua) by mail.terabit.net.ua with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63 (FreeBSD)) (envelope-from ) id 1LArfM-0002UK-Kc; Thu, 11 Dec 2008 21:57:44 +0200 Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id mBBJvfXc068295 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Dec 2008 21:57:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id mBBJvfT8043290; Thu, 11 Dec 2008 21:57:41 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id mBBJvfgv043289; Thu, 11 Dec 2008 21:57:41 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 11 Dec 2008 21:57:41 +0200 From: Kostik Belousov To: Ed Schouten Message-ID: <20081211195741.GW2038@deviant.kiev.zoral.com.ua> References: <49381DD4.2000506@kasimir.com> <20081211175519.GD1176@hoeg.nl> <20081211190436.GE1176@hoeg.nl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UaIp6+ubhcbWp687" Content-Disposition: inline In-Reply-To: <20081211190436.GE1176@hoeg.nl> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: ClamAV version 0.93.3, clamav-milter version 0.93.3 on skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua X-Virus-Scanned: mail.terabit.net.ua 1LArfM-0002UK-Kc df5e49348b3b31d6758f26b057dc6e43 X-Terabit: YES Cc: FreeBSD Arch Subject: Re: [Patch] strnlen(3) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2008 19:57:47 -0000 --UaIp6+ubhcbWp687 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2008 at 08:04:36PM +0100, Ed Schouten wrote: > Hello all, >=20 > I've attached a patch, that adds strnlen(3) to libc. It also moves > strndup(3) out of __BSD_VISIBLE. I'll see if it survives `make universe' > and commit it soonish. Any comments? strndup shall stay under __BSD_VISIBLE, and strnlen declaration shall go unto this define too. Not doing this will pollute namespace for the POSIX revisions we are (partially) trying to support. I think that style recommends to put empty statements constituting loop body on the separate line, properly indented. --UaIp6+ubhcbWp687 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAklBcLQACgkQC3+MBN1Mb4hc0QCfRaQhtGxsWOHsh5Q+Dycz480E lwIAoMk09aA6jKHatnF0ugevMqOw6jK+ =hUm/ -----END PGP SIGNATURE----- --UaIp6+ubhcbWp687--