From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 7 07:41:13 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46AC416A4CF for ; Wed, 7 Apr 2004 07:41:13 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2AF1043D54 for ; Wed, 7 Apr 2004 07:41:13 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i37EeFbv091764 for ; Wed, 7 Apr 2004 07:40:15 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i37EeFxO091763; Wed, 7 Apr 2004 07:40:15 -0700 (PDT) (envelope-from gnats) Resent-Date: Wed, 7 Apr 2004 07:40:15 -0700 (PDT) Resent-Message-Id: <200404071440.i37EeFxO091763@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Nottebrock Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46FA816A4CE for ; Wed, 7 Apr 2004 07:31:06 -0700 (PDT) Received: from meitner.wh.uni-dortmund.de (meitner.wh.uni-dortmund.de [129.217.129.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0B2CF43D2F for ; Wed, 7 Apr 2004 07:31:06 -0700 (PDT) (envelope-from michaelnottebrock@gmx.net) Received: from lofi.dyndns.org (pc2-105.intern.meitner [10.3.12.105]) by meitner.wh.uni-dortmund.de (Postfix) with ESMTP id BEEE01675B2; Wed, 7 Apr 2004 16:29:36 +0200 (CEST) Received: from kiste.my.domain (kiste.my.domain [192.168.8.4]) by lofi.dyndns.org (8.12.10/8.12.10) with ESMTP id i37ETZan059268 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 7 Apr 2004 16:29:35 +0200 (CEST) (envelope-from michaelnottebrock@gmx.net) Received: from kiste.my.domain (localhost [127.0.0.1]) by kiste.my.domain (8.12.11/8.12.9) with ESMTP id i37ETZfG038061; Wed, 7 Apr 2004 16:29:35 +0200 (CEST) (envelope-from lofi@kiste.my.domain) Received: (from lofi@localhost) by kiste.my.domain (8.12.11/8.12.9/Submit) id i37ETYQ9037862; Wed, 7 Apr 2004 16:29:34 +0200 (CEST) (envelope-from lofi) Message-Id: <200404071429.i37ETYQ9037862@kiste.my.domain> Date: Wed, 7 Apr 2004 16:29:34 +0200 (CEST) From: Michael Nottebrock To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: timur@gnu.org Subject: ports/65291: samba-devel default installation is broken on FreeBSD 4.x X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2004 14:41:13 -0000 >Number: 65291 >Category: ports >Synopsis: samba-devel default installation is broken on FreeBSD 4.x >Confidential: no >Severity: serious >Priority: high >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Apr 07 07:40:15 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Michael Nottebrock >Release: FreeBSD 4.9-STABLE i386 >Organization: >Environment: System: FreeBSD kiste 4.9-STABLE FreeBSD 4.9-STABLE #1: Tue Mar 23 22:34:26 CET 2004 lofi@kiste:/usr/obj/usr/src/sys/KISTE i386 >Description: Kerberos detection fails on 4.x. The port Makefile reads the output of krb5-config into a variable but does not check if the krb5-config actually or if the returned string isn't empty. Thus, it never depends on security/heimdal in FreeBSD 4.x, causing the default port installation to fail during configure stage. Below is a fix, please review. >How-To-Repeat: >Fix: --- samba-devel.diff begins here --- Index: Makefile =================================================================== RCS file: /home/pcvs/ports/net/samba-devel/Makefile,v retrieving revision 1.114 diff -u -r1.114 Makefile --- Makefile 6 Apr 2004 11:56:20 -0000 1.114 +++ Makefile 7 Apr 2004 14:19:32 -0000 @@ -197,7 +197,7 @@ .if defined(WANT_KRB5) # Relay on PATH KRB5_PREFIX!= krb5-config --prefix -.if defined(KRB5_PREFIX) +.if defined(KRB5_PREFIX) && !empty (KRB5_PREFIX) CONFIGURE_ARGS+= --with-krb5=${KRB5_PREFIX} .elif defined(KRB5_HOME) && exists(${KRB5_HOME}/lib/libgssapi_krb5.a) CONFIGURE_ARGS+= --with-krb5=${KRB5_HOME} --- samba-devel.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: