From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 12 12:30:02 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 3E59830D for ; Fri, 12 Apr 2013 12:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 2142237F for ; Fri, 12 Apr 2013 12:30:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r3CCU1sH080894 for ; Fri, 12 Apr 2013 12:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r3CCU16m080893; Fri, 12 Apr 2013 12:30:01 GMT (envelope-from gnats) Resent-Date: Fri, 12 Apr 2013 12:30:01 GMT Resent-Message-Id: <201304121230.r3CCU16m080893@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tijl Coosemans Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CCB5A2A6 for ; Fri, 12 Apr 2013 12:26:41 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay004.isp.belgacom.be (mailrelay004.isp.belgacom.be [195.238.6.170]) by mx1.freebsd.org (Postfix) with ESMTP id 6D67A365 for ; Fri, 12 Apr 2013 12:26:40 +0000 (UTC) Received: from 187.169-241-81.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([81.241.169.187]) by relay.skynet.be with ESMTP; 12 Apr 2013 14:26:38 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.6/8.14.6) with ESMTP id r3CCQbVm053062 for ; Fri, 12 Apr 2013 14:26:37 +0200 (CEST) (envelope-from tijl@kalimero.tijl.coosemans.org) Received: (from tijl@localhost) by kalimero.tijl.coosemans.org (8.14.6/8.14.6/Submit) id r3CCQafh053061; Fri, 12 Apr 2013 14:26:36 +0200 (CEST) (envelope-from tijl) Message-Id: <201304121226.r3CCQafh053061@kalimero.tijl.coosemans.org> Date: Fri, 12 Apr 2013 14:26:36 +0200 (CEST) From: Tijl Coosemans To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.114 Subject: ports/177805: [patch] ports-mgmt/portlint: check for ftp/http mirror X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Tijl Coosemans List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2013 12:30:02 -0000 >Number: 177805 >Category: ports >Synopsis: [patch] ports-mgmt/portlint: check for ftp/http mirror >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Fri Apr 12 12:30:01 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Tijl Coosemans >Release: FreeBSD 10.0-CURRENT i386 >Organization: >Environment: >Description: Some ports like x11-fonts/liberation-fonts-ttf only have https mirrors in MASTER_SITES. That means the distfiles are unfetchable when downloads have to go through a proxy because libfetch does not support proxies for https. redports.org is affected by this: http://redports.org/~jkim/20130411183541-06771-113095/liberation-fonts-ttf-2.00. 1,1.log The distfile also doesn't seem to get on ftp.freebsd.org. Maybe because of the same reason? The attached patch makes portlint print a warning if there's no plain ftp or http mirror in MASTER_SITES. >How-To-Repeat: >Fix: --- portlint.patch begins here --- Index: src/portlint.pl =================================================================== --- src/portlint.pl (revision 315789) +++ src/portlint.pl (working copy) @@ -2484,6 +2484,7 @@ print "OK: seen MASTER_SITES, sanity checking URLs.\n" if ($verbose); my @sites = split(/\s+/, $1 // ''); + my $ftphttp = 0; my $skipnext = 0; foreach my $i (@sites) { if ($skipnext) { @@ -2496,12 +2497,16 @@ unless (&is_predefined($i, $file)) { print "OK: URL \"$i\" ok.\n" if ($verbose); + $ftphttp++ if ($i =~ /^(ftp|http):/); } } else { print "OK: non-URL \"$i\" ok.\n" if ($verbose); + $ftphttp++; } } + &perror("WARN", $file, -1, "no ftp/http mirror in MASTER_SITES.") + unless ($ftphttp); } else { &perror("WARN", $file, -1, "no MASTER_SITES found. is it ok?"); } --- portlint.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: