From owner-freebsd-sparc64@FreeBSD.ORG  Wed Mar 31 22:20:05 2010
Return-Path: <owner-freebsd-sparc64@FreeBSD.ORG>
Delivered-To: freebsd-sparc64@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6453A1065676
	for <freebsd-sparc64@hub.freebsd.org>;
	Wed, 31 Mar 2010 22:20:05 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 53A098FC0A
	for <freebsd-sparc64@hub.freebsd.org>;
	Wed, 31 Mar 2010 22:20:05 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2VMK5MO094375
	for <freebsd-sparc64@freefall.freebsd.org>;
	Wed, 31 Mar 2010 22:20:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2VMK5lS094374;
	Wed, 31 Mar 2010 22:20:05 GMT (envelope-from gnats)
Date: Wed, 31 Mar 2010 22:20:05 GMT
Message-Id: <201003312220.o2VMK5lS094374@freefall.freebsd.org>
To: freebsd-sparc64@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: sparc64/80410: commit references a PR
X-BeenThere: freebsd-sparc64@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Porting FreeBSD to the Sparc <freebsd-sparc64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>, 
	<mailto:freebsd-sparc64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-sparc64>
List-Post: <mailto:freebsd-sparc64@freebsd.org>
List-Help: <mailto:freebsd-sparc64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64>,
	<mailto:freebsd-sparc64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Mar 2010 22:20:05 -0000

The following reply was made to PR sparc64/80410; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: sparc64/80410: commit references a PR
Date: Wed, 31 Mar 2010 22:16:19 +0000 (UTC)

 Author: mav
 Date: Wed Mar 31 22:16:05 2010
 New Revision: 206017
 URL: http://svn.freebsd.org/changeset/base/206017
 
 Log:
   Make ng_ksocket fulfill lower protocol stack layers alignment requirements
   on platforms with strict alignment constraints.
   This fixes kernel panics on arm and probably other architectures.
   
   PR:		sparc64/80410
 
 Modified:
   head/sys/netgraph/ng_ksocket.c
 
 Modified: head/sys/netgraph/ng_ksocket.c
 ==============================================================================
 --- head/sys/netgraph/ng_ksocket.c	Wed Mar 31 22:11:19 2010	(r206016)
 +++ head/sys/netgraph/ng_ksocket.c	Wed Mar 31 22:16:05 2010	(r206017)
 @@ -902,12 +902,24 @@ ng_ksocket_rcvdata(hook_p hook, item_p i
  	struct sockaddr *sa = NULL;
  	int error;
  	struct mbuf *m;
 +#ifdef ALIGNED_POINTER
 +	struct mbuf *n;
 +#endif /* ALIGNED_POINTER */
  	struct sa_tag *stag;
  
  	/* Extract data */
  	NGI_GET_M(item, m);
  	NG_FREE_ITEM(item);
 -
 +#ifdef ALIGNED_POINTER
 +	if (!ALIGNED_POINTER(mtod(m, caddr_t), uint32_t)) {
 +		n = m_defrag(m, M_NOWAIT);
 +		if (n == NULL) {
 +			m_freem(m);
 +			return (ENOBUFS);
 +		}
 +		m = n;
 +	}
 +#endif /* ALIGNED_POINTER */
  	/*
  	 * Look if socket address is stored in packet tags.
  	 * If sockaddr is ours, or provided by a third party (zero id),
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"