From owner-freebsd-stable@FreeBSD.ORG Mon Apr 1 15:07:31 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id A2EB3BCC for ; Mon, 1 Apr 2013 15:07:31 +0000 (UTC) (envelope-from se@freebsd.org) Received: from nm1.bullet.mail.ird.yahoo.com (nm1.bullet.mail.ird.yahoo.com [77.238.189.58]) by mx1.freebsd.org (Postfix) with SMTP id 00F8FB2F for ; Mon, 1 Apr 2013 15:07:30 +0000 (UTC) Received: from [212.82.105.247] by nm1.bullet.mail.ird.yahoo.com with NNFMP; 01 Apr 2013 15:07:24 -0000 Received: from [46.228.39.57] by tm19.bullet.mail.ird.yahoo.com with NNFMP; 01 Apr 2013 15:07:24 -0000 Received: from [127.0.0.1] by smtp190.mail.ir2.yahoo.com with NNFMP; 01 Apr 2013 15:07:24 -0000 X-Yahoo-Newman-Id: 681576.48491.bm@smtp190.mail.ir2.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: u6_VfT4VM1nO.pvMuJAuoWSx3MRKufjSWcOQxo5.o95Tpdl ZrMQRdqDRu5UxFsIxyVNLVJMna7tti4vaM5uzcl2pLo03Ufcn.fMR3n7HRdK 12VENDluIOt.o9EXKU2kYrkTcFqzK0L.aQxsGvSpXGAXlCIESlspkJQaczV9 9AQ0liO70SD.gomCzDmUvayJeDcPldiYEFaFTCcbHOiUreFsjWE8pc5i2XAq nLcGAArHZYmEFkqDRwrP06ejtVZX7X4VoTs80sefFigEosr9InKgCaMdGB1. W.q.bLlvTNUaky5.9aW.OAJ0agB.bk9JoMWiUqcUT.aQ5lQxDm06skOWtEGB RQ6BQJnB0VDJSDHxJZyzNupwK._68ua3V7vuGm8MiCOpk6hp4pXRVfumRbv0 jeqrhexw8ysI9uoHk9lgz66xnCW5QVCWINRIygoMYhfbSoWEP_Q-- X-Yahoo-SMTP: iDf2N9.swBDAhYEh7VHfpgq0lnq. X-Rocket-Received: from [192.168.119.11] (se@87.153.62.169 with plain) by smtp190.mail.ir2.yahoo.com with SMTP; 01 Apr 2013 15:07:24 +0000 UTC Message-ID: <5159A2A8.3090705@freebsd.org> Date: Mon, 01 Apr 2013 17:07:20 +0200 From: Stefan Esser User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: freebsd-stable@freebsd.org Subject: Re: Any objections/comments on axing out old ATA stack? References: <51536306.5030907@FreeBSD.org> <20130331130409.GO3178@equilibrium.bsdes.net> <20130401131415.GQ3178@equilibrium.bsdes.net> In-Reply-To: <20130401131415.GQ3178@equilibrium.bsdes.net> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 15:07:31 -0000 Am 01.04.2013 15:14, schrieb Victor Balada Diaz: > Being able to configure quirks from loader.conf for disks AND controllers would be great > and is not hard to do. If you want i can do a patch in two weeks and send it to you. That > way it's easy to test disabling NCQ and/or other things in case of hitting a bug. Also > being able to modify the configuration without a kernel recompile would be a big > improvement because we could still use freebsd-update to keep systems updated. Something like: kern.cam.ada.0.quirks=1 to force 4KB sectors? No need to implement that, it is in -CURRENT (did not check -STABLE). But there is no quirk, that disables NCQ, currently, although it is easy to implement. See the places where "ADA_FLAG_CAN_NCQ" is set and make that value depend on a new quirk flag being unset ... But instead of setting that flag in the loader, it would be good to collect drive signatures that need it and to add quirk entries for them in ata_da.c ... Regards, STefan