From nobody Wed Feb 11 13:49:07 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fB0CR6tQQz6RVZl for ; Wed, 11 Feb 2026 13:49:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fB0CR4lJYz3ZdK for ; Wed, 11 Feb 2026 13:49:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770817747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BgELWEMn91OG3HO4mmA5g0htav0aOFK8IrJYXFu2QiQ=; b=fsMwUFnMXFJrPbe3sAqKbRvG9EI9z5uzlkys3UDFnARZA2giep0t53hkofYNS6474ghV9b VG7PwbgkKDRIUvQ0qXd7y+4pT//LcOZHwQ3giiWIEkPaSvDe3fCL6xUsbl/KPKQfq7fMTD sll73yZF4UhCJag75/HFUvoXWybS1yDfEwU9FbPneW+yanA6ATpcWq6f7o59eCxjV3/0Z+ vhiwX4sR5nV//nAmW76kQwakNK6atTrH0zv/fWwaKFJHUW/SITCIfjGJTO8Atm8hDbtgLz +eUz4Oa1FlvgD0949Iw0wTQfpvCWiH69ipfx7IPWk+ScRdNpiPbbvNxlAW3j7A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770817747; a=rsa-sha256; cv=none; b=OPtoUOseKtXWL/KEk8tIOcwfikCUtUtVE8C4SqtQf6HiNxyIMIMh9hrOgdiyaayM15dnE7 YDsSDGj5N75YRbW2iO8MET3zNCVBQfeI10xThq5lULbSzf93aEK+ETyAsC1sa7ABfQRgc0 xcb0RhM5kQxSlC8PxrwLjIQomrgKBuXqB03BbO1njGXgzjPjcg4tQ+P0hBCIr67PsvjeRq wH5iSOXVEWv51F2GHMiI03m47q5U16wGfYS9nZQP0E+mi5t8gchNgUU7PZS0NM82YINDL+ PKiM3FHbH1jwn2gCrVT+IWn2ZoOvaPwSvQsQVKA5Z9ZS4aP6S4Zmdy9QKRrL8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770817747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BgELWEMn91OG3HO4mmA5g0htav0aOFK8IrJYXFu2QiQ=; b=FQvdYf7wh5z5UKWgISwra5UnN+GsCeTAYRLF9ST96NzSmxkQE0PcWcLd76Mph5WjlrstIi Uk0TjFhUmqL7i2deFUce4ov3zc4dp/2C6n0bVrLEwZ2FspFogl3sdYGYLVaB0CfTpRCy9P f1rejgjNgjYfKRwrj4SbwaYCBQFJ0OFiI520SBQYZY4WmIm+mRSa5gGJNBorVXtmrkxxZL ghcMwD91piPJavM+1a5plmD5GSgmJgCpKG/GjpZmwpo6vC9cM4l1t7WzMf0vEi45p0+qV1 0swC3ZljNkVluIzNqXqU2XzZ+2yXSQAjvSyGF6P8ZaHCZZfxfdAe9T9vOggJ8A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fB0CR3T6Yzs3H for ; Wed, 11 Feb 2026 13:49:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3be17 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 11 Feb 2026 13:49:07 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: ee6495580925 - stable/14 - qlnxe: Avoid reinitializing the interface when it is already initialized List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: ee6495580925b337f5851b6ee0f1188f81d7a6c8 Auto-Submitted: auto-generated Date: Wed, 11 Feb 2026 13:49:07 +0000 Message-Id: <698c88d3.3be17.74fae6f4@gitrepo.freebsd.org> The branch stable/14 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=ee6495580925b337f5851b6ee0f1188f81d7a6c8 commit ee6495580925b337f5851b6ee0f1188f81d7a6c8 Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:54 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-11 13:48:08 +0000 qlnxe: Avoid reinitializing the interface when it is already initialized qlnx_init_locked() unconditionally uninitialize the interface thus is actually reinitializing the interface. Well the init routine qlnx_init() is to initialize the interface by net stack when assigned with the first inet or inet6 address. The ioctl SIOCSIFADDR for the first inet6 address is handled by ether_ioctl() thus the interface is reinitialized no matter it was initialized or not. Add a driver status check for that to avoid reinitializing. Further plan is removing SIOCSIFADDR ioctl from the driver and let ether_ioctl() handle it. Reviewed by: kbowling MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54887 (cherry picked from commit c10e6bc0f0079e90cb484323ad71d437f1882422) (cherry picked from commit 8731ff4871d5397bae65bf184c44629a52c0e97b) --- sys/dev/qlnx/qlnxe/qlnx_os.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index b0dac3a82582..bc0282e3c22b 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2431,7 +2431,8 @@ qlnx_init(void *arg) QL_DPRINT2(ha, "enter\n"); QLNX_LOCK(ha); - qlnx_init_locked(ha); + if ((if_getdrvflags(ha->ifp) & IFF_DRV_RUNNING) == 0) + qlnx_init_locked(ha); QLNX_UNLOCK(ha); QL_DPRINT2(ha, "exit\n");