From owner-svn-src-head@freebsd.org Sat Sep 14 10:36:31 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5569F017A; Sat, 14 Sep 2019 10:36:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Vpp74qlGz3Jcv; Sat, 14 Sep 2019 10:36:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 3EE5C15E0D; Sat, 14 Sep 2019 10:36:31 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:470:7a58::19b1:7fa4:cdc6:3be2] (unknown [IPv6:2001:470:7a58:0:19b1:7fa4:cdc6:3be2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 468EC670C8; Sat, 14 Sep 2019 12:36:30 +0200 (CEST) From: Dimitry Andric Message-Id: <2D5BFAF9-7A03-4A2C-B406-19AA8BC8BF5D@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: svn commit: r352275 - in head/lib/libedit: . TEST edit readline Date: Sat, 14 Sep 2019 12:36:24 +0200 In-Reply-To: Cc: Peter Jeremy , Baptiste Daroussin , Charlie Li , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Warner Losh References: <201909130650.x8D6o2fb037276@repo.freebsd.org> <6fadeb6b-fe09-f3c7-9bca-b5637bbb4e43@vishwin.info> <20190914041041.GA97181@server.rulingia.com> X-Mailer: Apple Mail (2.3445.104.11) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 10:36:31 -0000 --Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 14 Sep 2019, at 06:25, Warner Losh wrote: >=20 > On Fri, Sep 13, 2019, 10:11 PM Peter Jeremy = wrote: > On 2019-Sep-13 16:33:15 -0400, Charlie Li = wrote: > >Baptiste Daroussin wrote: > >> Author: bapt > >> Date: Fri Sep 13 06:50:02 2019 > >> New Revision: 352275 > >> URL: https://svnweb.freebsd.org/changeset/base/352275 > >> > >> Log: > >> Update libedit to a snapshot from 2019-09-10 > >> Reviewed by: Yuichiro Naito > >> MFC after: 3 weeks > >> Differential Revision: https://reviews.freebsd.org/D21584 > >> > >I posted in phab but repeating here, this breaks the build on (at = least) > >aarch64: >=20 > It breaks the build on arm and arm64 only. >=20 > wint_t is int on all platforms: > sys/sys/_types.h: > typedef int __ct_rune_t; /* arg type for ctype funcs */ > typedef __ct_rune_t __wint_t; /* wint_t (see above) */ >=20 > but wchar_t varies between unsigned and signed: > $ grep '__wchar_t' sys/*/include/_types.h > sys/arm/include/_types.h:typedef unsigned int ___wchar_t; > sys/arm64/include/_types.h:typedef unsigned int ___wchar_t; > sys/mips/include/_types.h:typedef int ___wchar_t; > sys/powerpc/include/_types.h:typedef int ___wchar_t; > sys/riscv/include/_types.h:typedef int ___wchar_t; > sys/sparc64/include/_types.h:typedef int ___wchar_t; > sys/x86/include/_types.h:typedef int ___wchar_t; >=20 > Looking back into history, it looks like the "unsigned" is part > of the ARM EABI. >=20 > We should confirm that. It is definitely part of the OABI stuff, but = EABI was supposed to fix differences like this... As far as I know, arm has always been the odd one out, but even then, you should assume anything about the signedness of char. :) In any case, I have put up a fix for review here, which sidesteps that issue: https://reviews.freebsd.org/D21657 -Dimitry --Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXXzCqAAKCRCwXqMKLiCW ozx9AJ444XH15u1oO1QhjtwQJ3iBDNTdVgCg8Lp0HLCGxH7ZUaGKrFaMfRFJusU= =ix0J -----END PGP SIGNATURE----- --Apple-Mail=_4B83A316-21D1-46A8-ACB1-444D07C617CC--