From nobody Wed May 22 10:36:31 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vknng0TsYz5LRg8; Wed, 22 May 2024 10:37:59 +0000 (UTC) (envelope-from dsl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vknnf74dcz4xYt; Wed, 22 May 2024 10:37:58 +0000 (UTC) (envelope-from dsl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716374279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EBkOcq3mRcu/zQ2HrUhi5pMKMi9K6abTiRmyZ2zb2lM=; b=chqgKM4w93FYkK+4Z8WniyNz1EGUrSAHnSdqCfQlgyfErdK3mKD642bK1iH8usAWW8/wSt u/lppQZj+3+Lr4yJgOu1LADcra60l7QJSW829EC4NQP9tm62nPOxy23S1y5lDR8dqrWUza STOps8/VhASgGtUBZssnZ8IqLFBKOqIT92ZX/gI0zLsIsMREgswhfiV978RGqVOl8Oyca+ MrwROV2wC+Gr3EJt/HwEDlQPJfadg5CQkl6Eu5S9iVgJJnGY6tVzRo+NFw11WjuBHjbi7Y jBuwQj7KBJanjVdi5T4L4euKgJSDQKVbaFhl1HaTgYudyf/hDL9+R1mnjx5AaA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716374279; a=rsa-sha256; cv=none; b=bdFCfxutCXJzOKjNh5RKOjWgMxrsmALr1vJHOwacBGKw1C+0LulSRvviWxCmvXtIwePFZ/ v9xgEirVFf7vJ1eQkz0Osc+l1w1Fs4lTiqX7b5grStnO9GhSKCs5PLNWfujymkQeMimd2q dV3z3/cLcUNx/oyXUBGD2rfO0C/eZtvMCrfusuxZrHN1kb/ooFDqNZEgCaYJDJJjNQp8aa /+A+MLPvh6svYB8ITNpeYiXO+FTjJtr1FG4iiie5kJeivQHr9Etf8PG7EBmXenrpsUwCzM IQUiZOvWxc1yEt3oSR6mEsYaOCaWGld6VFtkYLlEhCQrvaokzw9rKw3E3rpzXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716374279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EBkOcq3mRcu/zQ2HrUhi5pMKMi9K6abTiRmyZ2zb2lM=; b=liOQs7/ywljmlOAf3sY2CDOnURdCJ8aYkbCwP4iIQzgiZ+WSNYkuS04gM4Y+HZONCCXk3V HEN68UOwSpqOVbsFEORLtilI+GgEKmjncXSPSpxcouKdvL9gkxn1LSydoDm4AP+RwfcSX8 ++NOAi4cWqQ92a3Sm5b0H/qFNFo+iW5ONw/OhZLB/RPuKAXY4Lh0ME9Rvug19XJONJyb2C gVES2F+wi+HeYgKU/V4FnsSXKrXj2xbky2hw5Krd/+kYCYWlXaWYEi3B6wpY3HiJ847I9X N19BuwBbh2AbdTutTFv0vtNFNFwQOspJQI48Z+hscuWgeXm1khJk226SIHMw4w== Received: from localhost (unknown [91.226.51.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: dsl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vknnf4dr6zfcv; Wed, 22 May 2024 10:37:58 +0000 (UTC) (envelope-from dsl@FreeBSD.org) References: <202405212004.44LK4cBG042804@gitrepo.freebsd.org> User-agent: mu4e 1.8.13; emacs 29.3 From: Dmitry Salychev To: Lexi Winter Cc: Mariusz Zaborski , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 408957613bc0 - main - Regen Date: Wed, 22 May 2024 12:36:31 +0200 In-reply-to: Message-ID: <86r0dugmik.fsf@peasant.tower.home> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain Lexi Winter writes: > [[PGP Signed Part:Undecided]] > Mariusz Zaborski: >> The branch main has been updated by oshogbo: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=408957613bc065c4444812c3ae276ace03697ebd >> >> commit 408957613bc065c4444812c3ae276ace03697ebd >> Author: Mariusz Zaborski >> AuthorDate: 2024-05-21 20:02:50 +0000 >> Commit: Mariusz Zaborski >> CommitDate: 2024-05-21 20:03:20 +0000 >> >> Regen >> --- >> sys/compat/freebsd32/freebsd32_sysent.c | 2 +- >> sys/kern/init_sysent.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) > > i'm sorry if this is considered accepted practice in FreeBSD (i'm not a > committer) but could i please request more useful commit messages than > "Regen" for things like this? > > when looking through 'git log', especially 'git log --format=oneline', > it's really not clear what this commit actually does, meaning if i'm > looking through the log for commits related to a problem i'm having, i > have to examine commits like this by hand to see if they're related. > > it would save me (and other people, i suppose) a lot of time if the > commit message could at least mention what it's touching, e.g. "Regen > sys/compat/freebsd32/freebsd32_sysent.c". > > [[End of PGP Signed Part]] Looks like it slipped in by mistake. I expected it to be reverted and re-worded. Regards, Dmitry -- https://wiki.freebsd.org/DmitrySalychev