From owner-svn-src-head@FreeBSD.ORG  Fri Nov 21 21:16:12 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 54E03106;
 Fri, 21 Nov 2014 21:16:12 +0000 (UTC)
Received: from vlakno.cz (mail.vlakno.cz [91.217.96.224])
 by mx1.freebsd.org (Postfix) with ESMTP id 16E74CEE;
 Fri, 21 Nov 2014 21:16:11 +0000 (UTC)
Received: by vlakno.cz (Postfix, from userid 1002)
 id 9F4A71D7ED7C; Fri, 21 Nov 2014 22:16:01 +0100 (CET)
Date: Fri, 21 Nov 2014 22:16:01 +0100
From: Roman Divacky <rdivacky@vlakno.cz>
To: Bruce Evans <brde@optusnet.com.au>
Subject: Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random
 geom/bde
Message-ID: <20141121211601.GA47019@vlakno.cz>
References: <201411100944.sAA9icnN061962@svn.freebsd.org>
 <3C962D07-3AAF-42EA-9D3E-D8F6D9A812B0@FreeBSD.org>
 <86sihq5a2v.fsf@nine.des.no> <20141111223756.F3519@besplex.bde.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=unknown-8bit
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20141111223756.F3519@besplex.bde.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, Dag-Erling Sm??rgrav <des@des.no>,
 svn-src-all@freebsd.org, "Bjoern A. Zeeb" <bz@freebsd.org>,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Nov 2014 21:16:12 -0000

On Tue, Nov 11, 2014 at 10:48:36PM +1100, Bruce Evans wrote:
> On Tue, 11 Nov 2014, [utf-8] Dag-Erling Smørgrav wrote:
> 
> > "Bjoern A. Zeeb" <bz@FreeBSD.org> writes:
> >> This fails to compile on all gcc platforms.
> >>
> >> cc1: warnings being treated as errors
> >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c:
> >> In function 'rijndael_padEncrypt':
> >> /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c:236:
> >> warning: cast discards qualifiers from pointer target type
> >> [...]
> >
> > The code is quite clearly wrong.  Why doesn't clang complain?
> 
> -Wcast-qual is broken (has no effect) with clang.  This is incompatible
> with gcc and defeats the reason of existence of -Wcast-qual.

I implemented -Wcast-qual in clang. We might want to backport it to our 3.4
(3.5 when it's imported), to prevent breakages like this in future.

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20141117/118946.html

Roman