From owner-freebsd-current Thu Jan 16 13:46:30 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 36AD737B401 for ; Thu, 16 Jan 2003 13:46:28 -0800 (PST) Received: from crucible.athame.co.uk (guru164.netsonic.fi [194.29.193.164]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7F67543ED8 for ; Thu, 16 Jan 2003 13:46:27 -0800 (PST) (envelope-from andy@athame.co.uk) Received: from amavis by crucible.athame.co.uk with scanned-ok (Exim 3.33 #1) id 18ZHq8-0005ck-00 for current@freebsd.org; Thu, 16 Jan 2003 23:46:20 +0200 Received: from zappa.int.athame.co.uk ([192.168.1.3] helo=zappa.athame.co.uk) by crucible.athame.co.uk with esmtp (Exim 3.33 #1) id 18ZHq3-0005cT-00; Thu, 16 Jan 2003 23:46:15 +0200 From: Andy Fawcett To: Sean Kelly , current@freebsd.org Subject: Re: x11/kdebase3 build? Date: Thu, 16 Jan 2003 23:46:25 +0200 User-Agent: KMail/1.5 References: <20030116211424.GA70354@edgemaster.zombie.org> In-Reply-To: <20030116211424.GA70354@edgemaster.zombie.org> Cc: kde@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200301162346.26059.andy@athame.co.uk> X-Virus-Scanned: by AMaViS perl-11 at crucible.athame.co.uk Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thursday 16 January 2003 23:14, Sean Kelly wrote: > I'm not entirely sure this belongs on -CURRENT, but I couldn't find > any KDE specific list similar to -gnome kde@FreeBSD.org will get you there. > and I seem to recall that the > building of KDE3 was a desired goal for FreeBSD 5.0. It is. > That said, I > apologize in advance if this is the wrong place to take this. > memory_fbsd.cpp:33: `VM_METER' undeclared (first use this function) As separately explained by Bruce, this has been changed on -current as a result of an old old PR. To be honest, replacing the old #define would seem to be too drastic a fix, bearing in mind that there's probably quite a few pieces of software out there that use it. How about: #define VM_TOTAL 1 /* struct vmtotal */ /* The following define is deprecated in favour of the above one and should not be used in new code */ #define VM_METER 1 /* struct vmmeter */ This would make code build on FreeBSD versions with either definition, without having to have horrible workarounds to work on them both. Or worse, programmers stopping using the name and just using the value 1 instead, which would be easy and very nasty to follow. As it is at the moment, I can see something like: #ifndef VM_METER #define VM_METER VM_TOTAL #endif springing up all over the place... Regards, Andy -- Andy Fawcett | andy@athame.co.uk | tap@kde.org "In an open world without walls and fences, | tap@lspace.org we wouldn't need Windows and Gates." -- anon | tap@fruitsalad.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message