From owner-freebsd-bugs@FreeBSD.ORG Sun Dec 19 05:40:30 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7197716A4CE for ; Sun, 19 Dec 2004 05:40:30 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2C89943D48 for ; Sun, 19 Dec 2004 05:40:30 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBJ5eRd5075776 for ; Sun, 19 Dec 2004 05:40:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBJ5eRvf075775; Sun, 19 Dec 2004 05:40:27 GMT (envelope-from gnats) Resent-Date: Sun, 19 Dec 2004 05:40:27 GMT Resent-Message-Id: <200412190540.iBJ5eRvf075775@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ken Westerback Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2351816A4CE for ; Sun, 19 Dec 2004 05:36:30 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 18B1943D31 for ; Sun, 19 Dec 2004 05:36:30 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id iBJ5aT6L095896 for ; Sun, 19 Dec 2004 05:36:29 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id iBJ5aT7j095880; Sun, 19 Dec 2004 05:36:29 GMT (envelope-from nobody) Message-Id: <200412190536.iBJ5aT7j095880@www.freebsd.org> Date: Sun, 19 Dec 2004 05:36:29 GMT From: Ken Westerback To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: kern/75250: timedout_scbs is not initialized with LIST_INIT() X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Dec 2004 05:40:30 -0000 >Number: 75250 >Category: kern >Synopsis: timedout_scbs is not initialized with LIST_INIT() >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 19 05:40:27 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Ken Westerback >Release: n/a >Organization: OpenBSD >Environment: n/a (OpenBSD) >Description: The list timedout_scbs in ahd_softc is not initialized anywhere I can find. The diff below adds a LIST_INIT(&ahd->timedout_scbs) to ahd_alloc(), which is where the similar list pending_scbs is initialized. Found while trying to upgrade the OpenBSD ahd driver with the latest FreeBSD goodies. I note that a similar problem may exist on ahc, but I haven't started sync'ing ahc yet. >How-To-Repeat: >Fix: Index: aic79xx.c =================================================================== RCS file: /home/ncvs/src/sys/dev/aic7xxx/aic79xx.c,v retrieving revision 1.33 diff -u -r1.33 aic79xx.c --- aic79xx.c 18 Nov 2004 20:22:30 -0000 1.33 +++ aic79xx.c 19 Dec 2004 05:23:19 -0000 @@ -5246,6 +5246,7 @@ return (NULL); } LIST_INIT(&ahd->pending_scbs); + LIST_INIT(&ahd->timedout_scbs); /* We don't know our unit number until the OSM sets it */ ahd->name = name; ahd->unit = -1; >Release-Note: >Audit-Trail: >Unformatted: