Date: Thu, 22 Dec 2011 22:38:45 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Dag-Erling Sm??rgrav <des@des.no> Cc: svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r228809 - vendor/openpam/dist/lib Message-ID: <20111222183845.GT80057@FreeBSD.org> In-Reply-To: <86bor0sbra.fsf@ds4.des.no> References: <201112221810.pBMIAFlo028054@svn.freebsd.org> <20111222182219.GS80057@FreeBSD.org> <86bor0sbra.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 22, 2011 at 07:27:05PM +0100, Dag-Erling Sm??rgrav wrote: D> Gleb Smirnoff <glebius@FreeBSD.org> writes: D> > I haven't yet tested this, but code looks like it is not going to print D> > anything in a case I don't have /usr/local/bin/pam_foo.so, while purpose D> > of the patch is to avoid logging of failure to open D> > /usr/local/bin/pam_foo.so.5. D> > D> > Although openpam_dynamic() will do some logging of errno value, the name D> > of the failed file won't be logged. If I got a lot of modules configured, D> > then I can't figure out which one is ENOENT. D> > D> > IMHO, some no_log flag should be passed down from the try_dlopen() to fix D> > the issue correctly. D> D> Index: openpam_dynamic.c D> =================================================================== D> --- openpam_dynamic.c (revision 509) D> +++ openpam_dynamic.c (working copy) D> @@ -124,7 +124,7 @@ D> dlclose(dlh); D> FREE(module); D> err: D> - openpam_log(PAM_LOG_ERROR, "%m"); D> + openpam_log(PAM_LOG_ERROR, "%s: %m", path); D> return (NULL); D> } If you don't mind, I'd prefer printing vpath here. Looks like in some cases the path may be not absolute, and informing user of open failure is more useful when an exact path where open failed is logged. This would require shifting FREE(vpath) down the function, I hope this isn't a problem. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111222183845.GT80057>