From owner-svn-src-all@freebsd.org Tue Oct 20 18:32:37 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A89FFA1A2C5; Tue, 20 Oct 2015 18:32:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 85E5A1B49; Tue, 20 Oct 2015 18:32:37 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 9C468B94F; Tue, 20 Oct 2015 14:32:36 -0400 (EDT) From: John Baldwin To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289633 - head/sys/ofed/include/linux Date: Tue, 20 Oct 2015 11:04:46 -0700 Message-ID: <1878746.bHLk1ML9QM@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201510201602.t9KG2BeA079785@repo.freebsd.org> References: <201510201602.t9KG2BeA079785@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 20 Oct 2015 14:32:36 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 18:32:37 -0000 On Tuesday, October 20, 2015 04:02:11 PM Hans Petter Selasky wrote: > Author: hselasky > Date: Tue Oct 20 16:02:11 2015 > New Revision: 289633 > URL: https://svnweb.freebsd.org/changeset/base/289633 > > Log: > Add missing FreeBSD RCS keyword and SVN properties. > > Sponsored by: Mellanox Technologies > > Modified: > head/sys/ofed/include/linux/io-mapping.h (contents, props changed) > head/sys/ofed/include/linux/io.h (contents, props changed) > head/sys/ofed/include/linux/jhash.h (contents, props changed) > head/sys/ofed/include/linux/linux_compat.c (contents, props changed) > head/sys/ofed/include/linux/linux_idr.c (contents, props changed) > head/sys/ofed/include/linux/linux_radix.c (contents, props changed) > head/sys/ofed/include/linux/vmalloc.h (contents, props changed) > > Modified: head/sys/ofed/include/linux/io-mapping.h > ============================================================================== > --- head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 15:28:02 2015 (r289632) > +++ head/sys/ofed/include/linux/io-mapping.h Tue Oct 20 16:02:11 2015 (r289633) > @@ -1,3 +1,4 @@ > +/* $FreeBSD$ */ > /*- > * Copyright (c) 2010 Isilon Systems, Inc. > * Copyright (c) 2010 iX Systems, Inc. Just a note on style. Most headers put the tag below the license block like so from : /*- * Copyright (c) 1997,1998,2003 Doug Rabson * All rights reserved. * ... * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF * SUCH DAMAGE. * * $FreeBSD: head/sys/sys/bus.h 284088 2015-06-06 17:25:45Z marcel $ */ It would have been nice to be more consistent with the rest of the tree. Maybe look around next time to see if there is an existing style? > Modified: head/sys/ofed/include/linux/jhash.h > ============================================================================== > --- head/sys/ofed/include/linux/jhash.h Tue Oct 20 15:28:02 2015 (r289632) > +++ head/sys/ofed/include/linux/jhash.h Tue Oct 20 16:02:11 2015 (r289633) > @@ -18,6 +18,7 @@ > * > * I've modified Bob's hash to be useful in the Linux kernel, and > * any bugs present are surely my fault. -DaveM > + * $FreeBSD$ > */ Please fix this one to leave a blank line before the tag at least. -- John Baldwin