From owner-cvs-all Fri Nov 23 9:19:40 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 0D7C137B448; Fri, 23 Nov 2001 09:19:28 -0800 (PST) Received: (from brian@localhost) by freefall.freebsd.org (8.11.4/8.11.4) id fANHJS821442; Fri, 23 Nov 2001 09:19:28 -0800 (PST) (envelope-from brian) Message-Id: <200111231719.fANHJS821442@freefall.freebsd.org> From: Brian Somers Date: Fri, 23 Nov 2001 09:19:28 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/ppp ncpaddr.c route.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG brian 2001/11/23 09:19:27 PST Modified files: usr.sbin/ppp ncpaddr.c route.c Log: Be paranoid about non-zero netmasks being associated with INET addresses of 0.0.0.0. The OpenBSD PF_ROUTE/NET_RT_DUMP sysctl is sending back routes with RTAX_NETMASK set, but the corresponding sockaddr being 4 zero bytes (with an address family of zero). ppp was getting confused by this and ending up interpreting it as a 0.0.0.0/32 routing table destination and subsequently failing to do anything with the route. Specifically, after this fix, ppp under OpenBSD can successfully change and delete the default route again ! Revision Changes Path 1.6 +18 -5 src/usr.sbin/ppp/ncpaddr.c 1.80 +2 -0 src/usr.sbin/ppp/route.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message