From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 30 19:20:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 3F8F142A for ; Wed, 30 Oct 2013 19:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0888E2C97; Wed, 30 Oct 2013 19:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r9UJK0NT083124; Wed, 30 Oct 2013 19:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r9UJK0tP083123; Wed, 30 Oct 2013 19:20:00 GMT (envelope-from gnats) Resent-Date: Wed, 30 Oct 2013 19:20:00 GMT Resent-Message-Id: <201310301920.r9UJK0tP083123@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Cc: kib@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Neudorf Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 681B9FE3 for ; Wed, 30 Oct 2013 19:11:58 +0000 (UTC) (envelope-from BM-2cXppXU4T67w7j6NCir9T1WdzBHmFgBnLj@bitmessage.ch) Received: from mail.bitmessage.ch (mail.bitmessage.ch [146.228.112.252]) by mx1.freebsd.org (Postfix) with SMTP id CB1EC2C34 for ; Wed, 30 Oct 2013 19:11:57 +0000 (UTC) Received: from nil ([127.0.0.1]) by mail.bitmessage.ch ; Wed, 30 Oct 2013 20:11:45 +0100 Message-Id: <20131030.86txfyh8vf@bitmessage.ch> Date: Wed, 30 Oct 2013 20:11:16 +0100 From: Stefan Neudorf To: FreeBSD-gnats-submit@freebsd.org X-GNATS-Notify: kib@FreeBSD.org Subject: bin/183494: [PATCH] usr.bin/limits: cannot set kqueues limit X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Oct 2013 19:20:01 -0000 >Number: 183494 >Category: bin >Synopsis: [PATCH] usr.bin/limits: cannot set kqueues limit >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 30 19:20:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Stefan Neudorf >Release: >Organization: >Environment: >Description: r256850 added kqueues limit but failed to update getopt() call leading to -k option (similar to sh's ulimit -k) not being recognized. >How-To-Repeat: $ limits -k 5 usage: limits [-C class|-P pid|-U user] [-eaSHBE] [-bcdflmnstuvpw [val]] [[name=val ...] cmd] >Fix: --- kqueues_limit.diff begins here --- Index: usr.bin/limits/limits.c =================================================================== --- usr.bin/limits/limits.c (revision 257346) +++ usr.bin/limits/limits.c (working copy) @@ -248,7 +249,7 @@ static struct { * to be modified accordingly! */ -#define RCS_STRING "tfdscmlunbvpw" +#define RCS_STRING "tfdscmlunbvpwk" static rlim_t resource_num(int which, int ch, const char *str); static void usage(void); @@ -287,7 +288,7 @@ main(int argc, char *argv[]) pid = -1; optarg = NULL; - while ((ch = getopt(argc, argv, ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:")) != -1) { + while ((ch = getopt(argc, argv, ":EeC:U:BSHP:ab:c:d:f:l:m:n:s:t:u:v:p:w:k:")) != -1) { switch(ch) { case 'a': doall = 1; @@ -544,7 +545,7 @@ usage(void) { (void)fprintf(stderr, "usage: limits [-C class|-P pid|-U user] [-eaSHBE] " - "[-bcdflmnstuvpw [val]] [[name=val ...] cmd]\n"); + "[-bcdflmnstuvpwk [val]] [[name=val ...] cmd]\n"); exit(EXIT_FAILURE); } --- kqueues_limit.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: