From owner-freebsd-ports-bugs@freebsd.org Fri Mar 31 20:30:32 2017 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91BB1D2768C for ; Fri, 31 Mar 2017 20:30:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68FC7DB3 for ; Fri, 31 Mar 2017 20:30:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2VKUWrJ068751 for ; Fri, 31 Mar 2017 20:30:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 218272] sysutils/qjail [Maintainer update] fix bugs Date: Fri, 31 Mar 2017 20:30:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: qjail1@a1poweruser.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 20:30:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218272 Bug ID: 218272 Summary: sysutils/qjail [Maintainer update] fix bugs Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: qjail1@a1poweruser.com Created attachment 181362 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D181362&action= =3Dedit port diff 1. Some people have firewalls that are not or cannot be configured to allow= ftp out. qjail used native ftp to download the base file issued by the "qjail install" logic. Changed it to use the "fetch http" command instead of the native ftp command.=20 2. Installed the hs-shellcheck package. Used it to check the qjail script. = Even though the qjail script has been in production mode for 7+ years, thought it would be good to verify the code was up to good standards. It found some th= ings that were not up to standard that I fixed. The changes in no way effected t= he existing logic flow. 3. Ran the updated qjail script through a testing cycle looking for any problems that may have been caused by the shellcheck changes I made. None w= ere found. 4. The testing cycle did bring to light three problems that unknowingly exi= sted before the shellcheck changes were made. A. The verify_ip routine was not working correctly. Fixed it. B. The bpf devfs rule 50 was not working correctly. Fixed it. C. Added check to -d option [# of jails to duplicate] of the=20 create function. No IPv6 addresses are allowed, only a single IPv4 address is allowed. 5. Ran shellcheck on "qjail.bootime" script and fixed same kind of things a= s in the qjail script. --=20 You are receiving this mail because: You are the assignee for the bug.=