From owner-cvs-ports@FreeBSD.ORG  Fri Aug 21 21:23:41 2009
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 07812106568D
	for <cvs-ports@FreeBSD.org>; Fri, 21 Aug 2009 21:23:41 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id A80EF8FC14
	for <cvs-ports@FreeBSD.org>; Fri, 21 Aug 2009 21:23:40 +0000 (UTC)
Received: (qmail 26341 invoked by uid 399); 21 Aug 2009 21:23:34 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 21 Aug 2009 21:23:34 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4A8F1050.3020206@FreeBSD.org>
Date: Fri, 21 Aug 2009 14:23:28 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.22 (X11/20090729)
MIME-Version: 1.0
To: Roman Bogorodskiy <novel@FreeBSD.org>
References: <200908211855.n7LItCIA072991@repoman.freebsd.org>
In-Reply-To: <200908211855.n7LItCIA072991@repoman.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/security/scanlogd Makefile
 ports/security/scanlogd/files scanlogd.in scanlogd.sh
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2009 21:23:41 -0000

Roman Bogorodskiy wrote:
> novel       2009-08-21 18:55:12 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/scanlogd    Makefile 
>   Added files:
>     security/scanlogd/files scanlogd.in 
>   Removed files:
>     security/scanlogd/files scanlogd.sh 
>   Log:
>   Improve USE_RC_SUBR usage.
>   
>   PR:             136849  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=136849
>   Submitted by:   pgollucci
>   
>   Revision  Changes    Path
>   1.9       +3 -9      ports/security/scanlogd/Makefile
>   1.1       +25 -0     ports/security/scanlogd/files/scanlogd.in (new)
>   1.5       +0 -25     ports/security/scanlogd/files/scanlogd.sh (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/Makefile.diff?&r1=1.8&r2=1.9&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/files/scanlogd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/files/scanlogd.sh

Thanks for committing this improvement. :)  Couple of notes on the
rc.d script, none of them life-threatening:

1. Unless this tool provides services that are needed for logging in,
"REQUIRE: DAEMON, BEFORE: LOGIN" should be replaced with "REQUIRE:LOGIN"
2. The default variable assignment should come after load_rc_config,
and should use just - instead of :-
3. In my last cleanup pass I missed the empty "required_files"
variable. That should be removed (or filled in, as appropriate).

As always, more info in
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

hth,

Doug

-- 

    This .signature sanitized for your protection