From owner-freebsd-bugs@FreeBSD.ORG Sat Oct 20 02:30:04 2007 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09B7516A418 for ; Sat, 20 Oct 2007 02:30:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C817413C45D for ; Sat, 20 Oct 2007 02:30:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9K2U3Be089388 for ; Sat, 20 Oct 2007 02:30:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9K2U3e0089384; Sat, 20 Oct 2007 02:30:03 GMT (envelope-from gnats) Date: Sat, 20 Oct 2007 02:30:03 GMT Message-Id: <200710200230.l9K2U3e0089384@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Nathan Whitehorn Cc: Subject: Re: misc/117349: gss_acquire_cred can crash if _gss_mech_oids has not been initialized X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Nathan Whitehorn List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Oct 2007 02:30:04 -0000 The following reply was made to PR misc/117349; it has been noted by GNATS. From: Nathan Whitehorn To: bug-followup@FreeBSD.org, nathanw@uchicago.edu Cc: Subject: Re: misc/117349: gss_acquire_cred can crash if _gss_mech_oids has not been initialized Date: Fri, 19 Oct 2007 20:56:02 -0500 The patch is backwards, of course. The correct patch is: --- gss_acquire_cred.c.dist 2007-10-19 20:12:26.000000000 -0500 +++ gss_acquire_cred.c 2007-10-19 20:12:40.000000000 -0500 @@ -59,6 +59,10 @@ * First make sure that at least one of the requested * mechanisms is one that we support. */ + + if (!_gss_mech_oids) + _gss_load_mech(); + if (mechs) { _gss_load_mech(); for (i = 0; i < mechs->count; i++)