Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 23 Dec 2024 16:52:48 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 2a6c77b343f6 - stable/14 - linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()
Message-ID:  <202412231652.4BNGqmRI040863@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=2a6c77b343f6789eb56bc42ccba12559a58b464c

commit 2a6c77b343f6789eb56bc42ccba12559a58b464c
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-12-13 20:28:13 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-12-23 16:51:33 +0000

    linuxkpi: Fix a lock leak in lkpi_sta_scan_to_auth()
    
    PR:             283015
    Reviewed by:    bz
    MFC after:      1 week
    Fixes:          0936c648ad0e ("LinuxKPI: 802.11: update the ni/lsta reference cycle")
    Differential Revision:  https://reviews.freebsd.org/D47949
    
    (cherry picked from commit 926905796749750da6464b97ec4f8eec0882cc0e)
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index 2bb0c2ab113c..f22ab8435a2f 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -1182,6 +1182,8 @@ lkpi_sta_scan_to_auth(struct ieee80211vap *vap, enum ieee80211_state nstate, int
 		    lvif, vap, vap->iv_bss, lvif->lvif_bss,
 		    (lvif->lvif_bss != NULL) ? lvif->lvif_bss->ni : NULL,
 		    lvif->lvif_bss_synched);
+		LKPI_80211_LVIF_UNLOCK(lvif);
+		ieee80211_free_node(ni);	/* Error handling for the local ni. */
 		return (EBUSY);
 	}
 	LKPI_80211_LVIF_UNLOCK(lvif);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202412231652.4BNGqmRI040863>