From nobody Wed Sep 17 12:19:09 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cRd9T6MqMz67Hl3; Wed, 17 Sep 2025 12:19:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cRd9T3Sbtz3Vdt; Wed, 17 Sep 2025 12:19:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vLg0ANXy9KTRAw4l5YoIz6EYh7USzf8XhKDplkgqfUI=; b=UAeC8W5Rx0Etsttnuc+51kxctjeGvX0GprhkDFC5/BmxnMUSNa22jsFcrP+3uDh6arjL3f d6Sf6LjfLJbhKoKFgrZwdBE7UFz9sMg8kkPt5WU8ipl/sXk7cgjurlEHP3xh9WpiW6WIlr 4rl2pggJWV6vHxdOjf0PjdAeJIo2HPcA7zP7TjraJBk9zWiXPGqkxAdwqNxbpA62ta8Kpl /qVXCzavJJ7M5rdoEIoFC/ksuIb2lMsSQgzSlHYvsilvteBLINyze2dPmPD19oApKQJmFh TMzillAYOGgGg6Vi/j3/3ohHIuJBqZHaXuAictT9nnmiQQ7zcIegTy/YRFkQ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758111549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vLg0ANXy9KTRAw4l5YoIz6EYh7USzf8XhKDplkgqfUI=; b=AjeCHyubd6T+v+35rVMWfTSgYaYy37SkxfyHyj8kU82tyLKMtF8O0D/IA47L/jyu8S2kJ3 UhNXyLffjMlC1kbsmr5a3TDllpjDnX9BNcc2IN4ChavsO2ICJe0g6S5LIVajHeQ4OgJGRv r52OWqkKXZtI9FAEcOlHjyHdya1+95QuzdzSwKmTQDTzUsoRyUudDJZjQ0ASpDgB1tOvfr CaYDh1LgjU+yyPCvJl9CNWyv02cQZ3WVhlsd62aS3jd7N/7Hjt/r7aQ+xNilXrzsoXE763 5xtiEMKPYz7pk6qrEUlwg9J+w0OZCnSQ7uomPBooDDHXksJSEDlyimLtu3qWlw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758111549; a=rsa-sha256; cv=none; b=N4ASfc3puxsAYlHaWAkjIeXRD5pgFJedsMqDIzLAtdcLVJXKzUa/D6faLzTerhSHDvd7H5 sV5vhS46dnADqowrFiwHW/ZM97YsU6Z/M36YQZoMBRA61EcCW/Ppf17L7XXg729qZb2doK 1oiAB+CVfJI/HHdaNBTf5DVN++CNsu1bH6s7pTFoz2dQJGFmJ6JVBbSXugz8d/x6642CNm X+QPm3E/yZgs3uN3zRLj0kddBe4TOt1JMI/b1Gt5UN+IGNrBvNHDP0QdbhJ1Z3HEohfEvu 0PAVcTu7Jv5VHejwKdM8QzDjZ5Z8jWi6sW2pCy5Z5B2Hu8Ty6j/rk2btpp46Vg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cRd9T2zVzz8yq; Wed, 17 Sep 2025 12:19:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58HCJ9Pd085885; Wed, 17 Sep 2025 12:19:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58HCJ9eO085882; Wed, 17 Sep 2025 12:19:09 GMT (envelope-from git) Date: Wed, 17 Sep 2025 12:19:09 GMT Message-Id: <202509171219.58HCJ9eO085882@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: b7a87d7c0dd1 - main - linux: setgroups(): Avoid allocation under the process lock List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b7a87d7c0dd19016e82f5d33f2c5ec90479c31fe Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=b7a87d7c0dd19016e82f5d33f2c5ec90479c31fe commit b7a87d7c0dd19016e82f5d33f2c5ec90479c31fe Author: Olivier Certner AuthorDate: 2025-08-28 15:47:38 +0000 Commit: Olivier Certner CommitDate: 2025-09-17 12:16:04 +0000 linux: setgroups(): Avoid allocation under the process lock This was missed in commit 838d9858251e ("Rework the credential code to support larger values of NGROUPS (...)"). No functional change (intended). MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52278 --- sys/compat/linux/linux_misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/linux/linux_misc.c b/sys/compat/linux/linux_misc.c index fb86de6e7302..0925ffb64480 100644 --- a/sys/compat/linux/linux_misc.c +++ b/sys/compat/linux/linux_misc.c @@ -1045,8 +1045,7 @@ linux_setgroups(struct thread *td, struct linux_setgroups_args *args) crextend(newcred, ngrp); p = td->td_proc; PROC_LOCK(p); - oldcred = p->p_ucred; - crcopy(newcred, oldcred); + oldcred = crcopysafe(p, newcred); if ((error = priv_check_cred(oldcred, PRIV_CRED_SETGROUPS)) != 0) { PROC_UNLOCK(p);