From owner-freebsd-arch@FreeBSD.ORG  Thu Dec 14 17:41:29 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 6349716A492
	for <freebsd-arch@freebsd.org>; Thu, 14 Dec 2006 17:41:29 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2F79743EC5
	for <freebsd-arch@freebsd.org>; Thu, 14 Dec 2006 17:27:38 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id kBEHSsuF039753;
	Thu, 14 Dec 2006 12:28:55 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: John Polstra <jdp@polstra.com>
Date: Thu, 14 Dec 2006 11:50:23 -0500
User-Agent: KMail/1.9.1
References: <XFMail.20061213153051.jdp@polstra.com>
In-Reply-To: <XFMail.20061213153051.jdp@polstra.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200612141150.23597.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Thu, 14 Dec 2006 12:28:55 -0500 (EST)
X-Virus-Scanned: ClamAV 0.88.3/2332/Thu Dec 14 09:54:27 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: freebsd-arch@freebsd.org
Subject: Re: Where do MSI quirks belong? [patch]
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2006 17:41:29 -0000

On Wednesday 13 December 2006 18:30, John Polstra wrote:
> On 12-Dec-2006 John Baldwin wrote:
> 
> > Updated patch (relative to the stuff I just committed) is at the
> > same location:
> > 
> > http://www.FreeBSD.org/~jhb/patches/msi_blacklist.patch
> > 
> > Can you review and possibly test it?
> 
> I reviewed the patch, and it looks fine except for two minor
> style mismatches.  The definitions of PCI_QUIRK_DISABLE_MSI and
> PCIB_DISABLE_MSI both have a tab after the #define, but in each case
> the preceding line used a space after the #define.  Hang your head
> in shame! ;-)

I can just fix the style bug in the old code then. :)

-- 
John Baldwin