From nobody Sat Oct 2 14:50:07 2021 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1A98017DC89C for ; Sat, 2 Oct 2021 14:50:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HM8z30B3Qz4Qwn for ; Sat, 2 Oct 2021 14:50:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D7F2914DF7 for ; Sat, 2 Oct 2021 14:50:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 192Eo61g066231 for ; Sat, 2 Oct 2021 14:50:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 192Eo6xb066230 for ports-bugs@FreeBSD.org; Sat, 2 Oct 2021 14:50:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 258846] devel/dyncall: unbreak on arm Date: Sat, 02 Oct 2021 14:50:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tphilipp@potion-studios.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D258846 --- Comment #6 from Tassilo Philipp --- Alright, I looked at it and ran some tests on 4 different arm platforms, an= d I cannot accept it as-is, but it's close. The main issue is it only unbreaks = arm w/ the clang integrated assembler when not using THUMB (in other words, the file you pointed out is not the only one to patch). I'll come up with a new patch. Details and/or other things while looking at it: - the %-prefixes were probably used b/c of x86 habits, they should be remov= ed indeed, thanks! - this is not the first time we have issues with clang's integrated assembl= er, we needed to change some PPC code also for v1.2 to make it happy - about the UAL/.syntax unified: this doesn't actually help for dyncall, b/c the ARM and THUMB calling conventions differ enough to need their own implementations, anyways.... yes, it would probably also be harmless to use those instruction names, but pre-UAL toolchains might break (and we do actu= ally use dyncall on some of those); I'm surprised that you listed it under "issu= es that prevent it from building on armv6/armv7", b/c I cannot reproduce that.= .. - depending on further tests, until v1.3 is out with the real fix, I might = make use of clang's -no-integrated-as to unbreak the build for the FreeBSD port.= .. I'll have a clearer picture, soon - I don't think I'll add TEST_TARGET, for already pointed out reasons; I understand that this isn't run automatically for the pkg building process, = but there is no point in running `make test` to only build (but not run) the te= sts - the target you probably wanted isn't 'tests' but 'run-tests', and for tho= se I should fix some exit codes, first; as said, this is on my to do list for dyncall 1.3 More to come, soon, thanks again for bringing this to my attention :) --=20 You are receiving this mail because: You are the assignee for the bug.=