From owner-cvs-all@FreeBSD.ORG Thu Jun 29 07:52:30 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92FB216A558; Thu, 29 Jun 2006 07:52:30 +0000 (UTC) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4562144975; Thu, 29 Jun 2006 07:52:30 +0000 (GMT) (envelope-from yar@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k5T7qUEx021640; Thu, 29 Jun 2006 07:52:30 GMT (envelope-from yar@repoman.freebsd.org) Received: (from yar@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k5T7qU06021639; Thu, 29 Jun 2006 07:52:30 GMT (envelope-from yar) Message-Id: <200606290752.k5T7qU06021639@repoman.freebsd.org> From: Yar Tikhiy Date: Thu, 29 Jun 2006 07:52:30 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jun 2006 07:52:30 -0000 yar 2006-06-29 07:52:30 UTC FreeBSD src repository Modified files: sys/net if_vlan.c Log: Detach the interface first, do vlan_unconfig() then. Previously, another thread could get a pointer to the interface by scanning the system-wide list and sleep on the global vlan mutex held by vlan_unconfig(). The interface was gone by the time the other thread woke up. In order to be able to call vlan_unconfig() on a detached interface, remove the purely cosmetic bzero'ing of IF_LLADDR from the function because a detached interface has no addresses. Noticed by: a stress-testing script by maxim Reviewed by: glebius Revision Changes Path 1.105 +3 -9 src/sys/net/if_vlan.c