From owner-freebsd-bugs@FreeBSD.ORG Wed Jan 30 17:30:02 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1BF916A419 for ; Wed, 30 Jan 2008 17:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 846D713C45D for ; Wed, 30 Jan 2008 17:30:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m0UHU2KH082460 for ; Wed, 30 Jan 2008 17:30:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m0UHU2jb082457; Wed, 30 Jan 2008 17:30:02 GMT (envelope-from gnats) Resent-Date: Wed, 30 Jan 2008 17:30:02 GMT Resent-Message-Id: <200801301730.m0UHU2jb082457@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Niki Denev Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B72616A421 for ; Wed, 30 Jan 2008 17:28:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 4034C13C4D5 for ; Wed, 30 Jan 2008 17:28:29 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0UHQeiX028375 for ; Wed, 30 Jan 2008 17:26:40 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m0UHQeHf028373; Wed, 30 Jan 2008 17:26:40 GMT (envelope-from nobody) Message-Id: <200801301726.m0UHQeHf028373@www.freebsd.org> Date: Wed, 30 Jan 2008 17:26:40 GMT From: Niki Denev To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/120162: unable to remount/update gjournaled fs with "current" option X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2008 17:30:02 -0000 >Number: 120162 >Category: bin >Synopsis: unable to remount/update gjournaled fs with "current" option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jan 30 17:30:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Niki Denev >Release: FreeBSD 7.0-BETA2 >Organization: >Environment: FreeBSD ndenev 7.0-BETA2 FreeBSD 7.0-BETA2 #5: Sat Nov 3 18:13:12 EET 2007 ndenev@ndenev:/usr/obj/usr/src/sys/XXX i386 >Description: When doing mount update with "current" option, mount(8) treats "gjournal" as mount option and tries to apply it. But "gjournal" is a flag, and not an mount option. >How-To-Repeat: do a : # mount -u -ocurrent $fs on a gjournaled $fs filesystem. >Fix: The applied patch to mount.c:flags2opts() fixes the problem by not reporting "gjournal" as option. Patch attached with submission follows: --- sbin/mount/mount.c.orig 2008-01-30 19:15:20.000000000 +0200 +++ sbin/mount/mount.c 2008-01-30 19:16:09.000000000 +0200 @@ -871,7 +871,6 @@ if (flags & MNT_SUIDDIR) res = catopt(res, "suiddir"); if (flags & MNT_MULTILABEL) res = catopt(res, "multilabel"); if (flags & MNT_ACLS) res = catopt(res, "acls"); - if (flags & MNT_GJOURNAL) res = catopt(res, "gjournal"); return (res); } >Release-Note: >Audit-Trail: >Unformatted: