From owner-svn-src-all@FreeBSD.ORG  Sun May  5 21:03:28 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id EE8AC963;
 Sun,  5 May 2013 21:03:27 +0000 (UTC)
 (envelope-from theraven@FreeBSD.org)
Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27])
 by mx1.freebsd.org (Postfix) with ESMTP id C320FDF3;
 Sun,  5 May 2013 21:03:27 +0000 (UTC)
Received: from [192.168.0.2]
 (cpc10-cmbg15-2-0-cust123.5-4.cable.virginmedia.com [86.30.246.124])
 (authenticated bits=0)
 by theravensnest.org (8.14.5/8.14.5) with ESMTP id r45L3ITm013956
 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
 Sun, 5 May 2013 21:03:20 GMT (envelope-from theraven@FreeBSD.org)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: svn commit: r250245 - head/lib/libc/locale
From: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <5186A598.8040403@freebsd.org>
Date: Sun, 5 May 2013 22:03:13 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <90B8EC0D-C669-4345-AAB7-DE880E667260@FreeBSD.org>
References: <201305041721.r44HLiXb066291@svn.freebsd.org>
 <5186A598.8040403@freebsd.org>
To: Andrey Chernov <ache@FreeBSD.org>
X-Mailer: Apple Mail (2.1499)
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 Sergey Kandaurov <pluknet@FreeBSD.org>, src-committers@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 May 2013 21:03:28 -0000

On 5 May 2013, at 19:31, Andrey Chernov <ache@FreeBSD.org> wrote:

> It is better to fix this function return type to match POSIX standard
> rather than to document its non-standard behavior. We try to follow
> POSIX when possible and this is the case.

We follow Darwin in this case, which returns 0 on success or -1 on =
error.  'Fixing' this will break code written for Darwin and testing the =
return value.  Not fixing it will not break POSIX code that ignores the =
(unexpected) return value.

David