From owner-freebsd-bugs@FreeBSD.ORG  Fri May  2 20:20:06 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 98148106564A
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  2 May 2008 20:20:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 81DE58FC17
	for <freebsd-bugs@hub.freebsd.org>;
	Fri,  2 May 2008 20:20:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m42KK6up007101
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 2 May 2008 20:20:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m42KK6tE007100;
	Fri, 2 May 2008 20:20:06 GMT (envelope-from gnats)
Date: Fri, 2 May 2008 20:20:06 GMT
Message-Id: <200805022020.m42KK6tE007100@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: John Baldwin <jhb@FreeBSD.org>
Cc: 
Subject: Re: kern/121433: [cpufreq] kern_cpu.c's logic error leads to
	spontaneous disabling of passive cooling
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: John Baldwin <jhb@FreeBSD.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 02 May 2008 20:20:06 -0000

The following reply was made to PR kern/121433; it has been noted by GNATS.

From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, eugen@kuzbass.ru
Cc:  
Subject: Re: kern/121433: [cpufreq] kern_cpu.c's logic error leads to spontaneous disabling of passive cooling
Date: Fri, 2 May 2008 16:16:20 -0400

 Try this patch:
 
 Index: kern_cpu.c
 ===================================================================
 RCS file: /usr/cvs/src/sys/kern/kern_cpu.c,v
 retrieving revision 1.29
 diff -u -r1.29 kern_cpu.c
 --- kern_cpu.c	16 Jan 2008 01:05:21 -0000	1.29
 +++ kern_cpu.c	2 May 2008 20:13:54 -0000
 @@ -452,8 +452,7 @@
  	for (n = 0; n < numdevs && curr_set->freq == CPUFREQ_VAL_UNKNOWN; n++) {
  		if (!device_is_attached(devs[n]))
  			continue;
 -		error = CPUFREQ_DRV_GET(devs[n], &set);
 -		if (error)
 +		if (CPUFREQ_DRV_GET(devs[n], &set) != 0)
  			continue;
  		for (i = 0; i < count; i++) {
  			if (CPUFREQ_CMP(set.freq, levels[i].total_set.freq)) {
 @@ -483,9 +482,10 @@
  		if (CPUFREQ_CMP(rate, levels[i].total_set.freq)) {
  			sc->curr_level = levels[i];
  			CF_DEBUG("get estimated freq %d\n", curr_set->freq);
 -			break;
 +			goto out;
  		}
  	}
 +	error = ENXIO;
  
  out:
  	if (error == 0)
 
 -- 
 John Baldwin