From owner-dev-commits-src-main@freebsd.org Fri Feb 26 21:53:07 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0BC00550571 for ; Fri, 26 Feb 2021 21:53:07 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DnNgk0RnWz3CgV; Fri, 26 Feb 2021 21:53:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x636.google.com with SMTP id u11so5983318plg.13; Fri, 26 Feb 2021 13:53:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ni+ufMMvq29sfeZdPxbHvWKi2t/+hbs7dsg1gDL0T8c=; b=EoSdD24myiZ4n/RycmzRwv5lyxIjbHBfh3/dotcREMA81W4kpr8zuuuDh6/s1BgI5b +aogACmjEgMkdmreCOyZH8AU7ejqz01ZyfeLu+YnhcgFMKrOtKLRFFBweHqJk1y4N2Zn zr3FsfpzCpXMZOkI3AQYDsl1Td2Y55/Rrft4afJ10yAc4nWS0OYsvk3FCn2Yobvi1+5Q RzKDLz4q9B2pqXNZqhos3dhAQ/Bg4a08CBlM0FptqzQYrgAst9zpmv6SPzF9z8wdUgOm iwc4Ybm2ez05I64Up0L0C+cYKMXGQ+OehHlul5YiS+PiGJfd47GJBZeJOk45w9s7j7jS 06EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Ni+ufMMvq29sfeZdPxbHvWKi2t/+hbs7dsg1gDL0T8c=; b=FMaYFY83fZo3cTY9M3cLtbpywjyj9lhTH9BLTlevA/gsK97oJ3UwNgv4zNvjVUCq/P c69vpEneD9LY2jU08513J9Q0A93m7XgzoDf8ESGqTdGWGzOovYb27rknMfAeNZbftoa8 YhbmwFBegdAb1AU9MS1sfST7k8kfxzpiytLSVQTixn67UOSUJmXfJgUb/noeKN2sM5mB yiLIJDm54Sns2QAfPTbAVWy27UQ3FzshSxIddF1l6GW1IXVlkPHrzoaM0gIHebzzBzQG t45ioOZYSViM3YktNmRnZ8W6PR5pxlzRZDoKUxkTFIiB9wkTxxo1LAYCGvmZDbidcZXz wx4Q== X-Gm-Message-State: AOAM533I9YmBh5/txh5SnsI791qlHgelmSdlXQ2JfFZOIWV2QVOtPi4G Ln1h/6Ydy7Zhn+/0ftdl6adVwYSUaScDPw== X-Google-Smtp-Source: ABdhPJz3CqBTc6UKgN93fNUb9qjImjoaiUcv2jQMgrcpVCmSYixn2TpdhE250PNE0MrIHLxhmhc0Pw== X-Received: by 2002:a17:902:8687:b029:e1:601e:bd29 with SMTP id g7-20020a1709028687b02900e1601ebd29mr4858188plo.47.1614376383904; Fri, 26 Feb 2021 13:53:03 -0800 (PST) Received: from [192.168.20.29] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id o4sm10118351pfg.107.2021.02.26.13.53.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Feb 2021 13:53:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 3775ddcf5a12 - main - tests/sys/netgraph: Tell kyua that perl is required From: Enji Cooper In-Reply-To: <202102231744.11NHi08p021198@gitrepo.freebsd.org> Date: Fri, 26 Feb 2021 13:53:02 -0800 Cc: Kristof Provost , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <53DA1EDF-3C9B-4573-AB30-EE3F581471AD@gmail.com> References: <202102231744.11NHi08p021198@gitrepo.freebsd.org> To: Alex Richardson X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DnNgk0RnWz3CgV X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=EoSdD24m; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.50 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::636:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[73.19.52.228:received]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::636:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::636:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[dev-commits-src-main] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 21:53:07 -0000 > On Feb 23, 2021, at 9:44 AM, Alex Richardson = wrote: >=20 > The branch main has been updated by arichardson: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D3775ddcf5a12c8e23970e94b7b165bf2= 3c92aeba >=20 > commit 3775ddcf5a12c8e23970e94b7b165bf23c92aeba > Author: Alex Richardson > AuthorDate: 2021-02-23 17:02:31 +0000 > Commit: Alex Richardson > CommitDate: 2021-02-23 17:43:31 +0000 >=20 > tests/sys/netgraph: Tell kyua that perl is required >=20 > Otherwise these tests fail with incomprehensible error messages. >=20 > Reviewed By: kp > Differential Revision: https://reviews.freebsd.org/D28894 It might be a good idea to rely on ${TAP_PERL_INTERPRETER} = instead, in the code, however=E2=80=A6 is there a reason why the = one-liners are written in perl instead of awk? Cheers, -Enji