From owner-freebsd-arch@FreeBSD.ORG Tue Oct 13 22:40:19 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F2871065672 for ; Tue, 13 Oct 2009 22:40:19 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-ew0-f218.google.com (mail-ew0-f218.google.com [209.85.219.218]) by mx1.freebsd.org (Postfix) with ESMTP id ACC868FC08 for ; Tue, 13 Oct 2009 22:40:18 +0000 (UTC) Received: by ewy18 with SMTP id 18so4282492ewy.43 for ; Tue, 13 Oct 2009 15:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=aMn18uzNMMVv2X1EcsiPqZI86EMTvTNNm7LyA+SX7tI=; b=FrhyNbPX0nsRVU7hGDY73rhENXcU3U8Ff370ga+TCS+eG+s7k4eEtKEZCMj67v3pbR hM0Vq8M8GyjfqPVqkFFyExsq5EDk1MrfXUAhas4iqBsjnkD3Jv9tJ0e4r9vkmCYgyu6G HoSLrxZ0qNyqL2UrKxvYsqOmewNWZ5LTgZw5M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=LFD9PtZ/vJgPUXqezKq58Aj8yXTPLaZqVWuk4znwSx3rGxlbmR2rNXVLBhB+FtWzHu HkAxs0egct5UAIhttbVzCoc4+E37fTNHTI/F6thBhWOGDTAWK86gIkUjUNy1RkCSZPvt Tey/I2seAtUBMRPB6etXWERKMlgB8qHfj1VE8= MIME-Version: 1.0 Received: by 10.216.87.136 with SMTP id y8mr533726wee.43.1255471620694; Tue, 13 Oct 2009 15:07:00 -0700 (PDT) In-Reply-To: <200910131748.57945.jhb@freebsd.org> References: <200909301732.20589.jhb@freebsd.org> <200910131748.57945.jhb@freebsd.org> Date: Tue, 13 Oct 2009 15:07:00 -0700 Message-ID: <2a41acea0910131507l3a50b68u698d876e96880266@mail.gmail.com> From: Jack Vogel To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-arch@freebsd.org Subject: Re: Interrupt Descriptions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2009 22:40:19 -0000 On Tue, Oct 13, 2009 at 2:48 PM, John Baldwin wrote: > On Wednesday 30 September 2009 5:32:20 pm John Baldwin wrote: > > A few folks have asked recently for the ability to add descriptive > strings > to > > registered interrupt handlers. This is especially true since the advent > of > > MSI with multiple interrupts per device. I hacked up a prototype today > that > > adds a new 'bus_describe_intr()' that takes the IRQ resource, the void * > > cookie returned by bus_setup_intr() and var args description and appends > that > > to the interrupt name in the thread and vmstat -i info. The current > patch > > only has the MI bits and the MD bits for amd64 as well as a sample change > to > > the igb(4) driver. > > > > The patch is at http://www.FreeBSD.org/~jhb/patches/intr_describe.patch > . > > > > An example from this patch is: > > > > > vmstat -i > > interrupt total rate > > irq1: atkbd0 8 0 > > irq4: uart0 751 5 > > irq6: fdc0 6 0 > > irq14: ata0 36 0 > > irq20: uhci0 20 0 > > irq23: uhci3 ehci0 2 0 > > irq28: mpt0 1661 11 > > irq256: igb0:tx 0 880 6 > > irq257: igb0:rx 0 1098 7 > > irq258: igb0:link 3 0 > > irq259: igb1:tx 0 1 0 > > irq260: igb1:rx 0 134 0 > > irq261: igb1:link 3 0 > > Do folks feel that the issues with the intrnames and intrcnt API warrant > delaying this work, or do folks have any objections to the proposed > bus_describe_intr() API? Personally I think that intrnames and intrcnt are > certainly broken, but that they have been broken for quite a while and that > these changes do not make them more broken than they currently are. Also, > I > think that any fixes to intrcnt/intrnames would be orthogonal to > bus_describe_intr(). > > I'm in favor of going with what you've done, and let fixes or changes happen later, having this functionality now would be really nice. Jack