From owner-svn-src-all@FreeBSD.ORG Fri Sep 6 05:42:03 2013
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
(No client certificate requested)
by hub.freebsd.org (Postfix) with ESMTP id 53E7C58A;
Fri, 6 Sep 2013 05:42:03 +0000 (UTC)
(envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.freebsd.org (Postfix) with ESMTPS id E5F2B2766;
Fri, 6 Sep 2013 05:42:02 +0000 (UTC)
Received: from tom.home (kostik@localhost [127.0.0.1])
by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r865fvZj045004;
Fri, 6 Sep 2013 08:41:57 +0300 (EEST)
(envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r865fvZj045004
Received: (from kostik@localhost)
by tom.home (8.14.7/8.14.7/Submit) id r865fvP2045003;
Fri, 6 Sep 2013 08:41:57 +0300 (EEST)
(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
using -f
Date: Fri, 6 Sep 2013 08:41:57 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Subject: Re: svn commit: r255246 - head/sys/sys
Message-ID: <20130906054157.GZ41229@kib.kiev.ua>
References: <201309051346.r85DkU6U045151@svn.freebsd.org>
<20130905140319.GX41229@kib.kiev.ua>
<20130905144439.GD4574@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="SnACAX3oZLWUNEDt"
Content-Disposition: inline
In-Reply-To: <20130905144439.GD4574@FreeBSD.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
version=3.3.2
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for "
user" and " projects" \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Sep 2013 05:42:03 -0000
--SnACAX3oZLWUNEDt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Sep 05, 2013 at 06:44:39PM +0400, Gleb Smirnoff wrote:
> On Thu, Sep 05, 2013 at 05:03:19PM +0300, Konstantin Belousov wrote:
> K> On Thu, Sep 05, 2013 at 01:46:30PM +0000, Gleb Smirnoff wrote:
> K> > Author: glebius
> K> > Date: Thu Sep 5 13:46:30 2013
> K> > New Revision: 255246
> K> > URL: http://svnweb.freebsd.org/changeset/base/255246
> K> >=20
> K> > Log:
> K> > Fix build.
> K> > counter.h requires systm.h
> K> >=20
> K> > Modified:
> K> > head/sys/sys/sf_buf.h
> K> >=20
> K> > Modified: head/sys/sys/sf_buf.h
> K> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D
> K> > --- head/sys/sys/sf_buf.h Thu Sep 5 12:56:08 2013 (r255245)
> K> > +++ head/sys/sys/sf_buf.h Thu Sep 5 13:46:30 2013 (r255246)
> K> > @@ -54,6 +54,7 @@ struct sfstat { /* sendfile statistic
> K> > =20
> K> > #ifdef _KERNEL
> K> > #include <machine/sf_buf.h>
> K> > +#include <sys/systm.h>
> K> > #include <sys/counter.h>
> K> > struct mbuf; /* for sf_buf_mext() */
> K> > =20
> K> IMO the counter.h (and sfstat, SFSTAT_INC) should be removed from the =
sf_buf.h.
>=20
> The problem is that SFSTAT_INC() is used in MD code.
Then MD code should start including additional header. This is probably
some amount of work, but the current situation is not acceptable. sf
buffers have overgrown the 'sendfile buffers' use case for long time.
--SnACAX3oZLWUNEDt
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (FreeBSD)
iQIcBAEBAgAGBQJSKWskAAoJEJDCuSvBvK1BooQP+QGa35k3vPFlyZKxZfdVOWzo
eVVgN3lA2q4S0ZMI3I0pd3Ap/bH9wV3QtoJu9Nyapwg8ESSDtkKg0SyF7RyY6uNF
au//JnjA0X7pERC1bS/enXoTZmg4KBLoR2Sg24SH1MOjw0rq0kgd6oJ+VME121wz
w4BhlvYSnyF7uF5kTnvowf+rmYUD+ztdLMMpFmGNlQBzKy7CMNz5QNFV3pevzM35
ONTWTCVgP4/Yxjwp6aOKWebW3FfhM4jKzPUlRkorez323eNzEeXn1eyXLe70aeIT
4KkOZCiMAvf8snVOnTggWuFbHkVleO26DRcmt5eLJdeiJFB41CHmU0wDA/RwqzpC
7fvuialpleuHhOxRxeoiKdCOOKrfnmvjw/DUC7tFZDLC/HxEeix02n5Tmk58/W+J
HHTbv2BK3UJFU0Lv6bCYIqODF0uC0meT/EphhfFppkgGb7l8RBMp4jC3nTjqakLP
QERciRlZy2NE4TJ+g1OZJBERUM350T2ZTGCmrAbOc2nWobbld4bvOTWIFfIIckRJ
R4YxSviQjWUIyqworYMPY9RJuzNcXiOsGMM3Bui4sqtMjAbltsp524bsJlY9kOuN
QR7UE36sAla4qEH6etYpiwlHwX0AlCrsRcZJiaebypufcxl1h3KCj6qzvSHavxRH
cosi8rMNJ2YwZPXwWYeP
=m9e6
-----END PGP SIGNATURE-----
--SnACAX3oZLWUNEDt--