From owner-svn-src-all@FreeBSD.ORG Thu Oct 2 01:31:06 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 687AFE0 for ; Thu, 2 Oct 2014 01:31:06 +0000 (UTC) Received: from o3.shared.sendgrid.net (o3.shared.sendgrid.net [208.117.48.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1C37ECBB for ; Thu, 2 Oct 2014 01:31:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sendgrid.info; h=from:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; s=smtpapi; bh=p6iDGWq1t9DSuD47Va0EeS7SgC8=; b=mPXHvFndCa+TmtkzhJ HuMYEqHy26iOMf1SoAU/Dk2do0HXVO93PlaT8tGrbAuMpA7KBc/yS7By7/gwd26Q U8f9ZfPq3fw5a9ZT/JmxNfc1fopYux8+k19diwwiyTahdgw6UN8meB1QFleOY6jf p+CAsDo9eJ7Fevx697NBRKuIU= Received: by filter0215p1mdw1.sendgrid.net with SMTP id filter0215p1mdw1.15174.542CAACE4 2014-10-02 01:30:58.336447139 +0000 UTC Received: from mail.tarsnap.com (unknown [10.100.60.97]) by ismtpd-004.iad1.sendgrid.net (SG) with ESMTP id 148ce7b7414.1917.2cd20e for ; Thu, 02 Oct 2014 01:31:10 +0000 (GMT) Received: (qmail 91469 invoked from network); 2 Oct 2014 01:30:57 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by ec2-107-20-205-189.compute-1.amazonaws.com with ESMTP; 2 Oct 2014 01:30:57 -0000 Received: (qmail 18543 invoked from network); 2 Oct 2014 01:30:36 -0000 Received: from unknown (HELO clamshell.daemonology.net) (127.0.0.1) by clamshell.daemonology.net with SMTP; 2 Oct 2014 01:30:36 -0000 Message-ID: <542CAABB.5090900@freebsd.org> Date: Wed, 01 Oct 2014 18:30:35 -0700 From: Colin Percival User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Hiroki Sato , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r272393 - head/etc References: <201410020116.s921GVTZ033933@svn.freebsd.org> In-Reply-To: <201410020116.s921GVTZ033933@svn.freebsd.org> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SG-EID: A6W2xSVPHetogaU8rnzccWwgBYtN+QvIzXyjfe/10PEuwbOutzKV4prYjGp4zJM88/daf+56R9KlkbxnG9M8HvAE39AKIyeVozazdqtES2drb2Yevnuxv0chyTPVetBPkyt13zy0hEXMqjxqmiZOlnVDfeZL3P3OYeyUX12HJ9ulKyRG8QRuyOVIsm9BaMC+ X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Oct 2014 01:31:06 -0000 On 10/01/14 18:16, Hiroki Sato wrote: > This is an attempt to solve a problem that rc.d scripts from third-party > software do not have entries in /etc/defaults/rc.conf. Isn't this why we have the > : ${foo_enable="NO"} idiom in ports rc.d files? > The fact that > load_rc_config() reads rc.conf only once and /etc/rc invokes the function > before running rc.d scripts made developers confused for a long time because > load_rc_config() just before run_rc_command() in each rc.d script overrides > variables only when the script is directly invoked, not from /etc/rc. If a script is setting variables for its own use, there's no need to use functions from rc.subr -- it can just set the variables directly. If a script is editing rc.conf, sending a SIGALRM to $$ will signal /etc/rc to re-source rc.conf. I'm really not clear on what this commit accomplishes. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid