From owner-cvs-all Wed May 22 10: 6:35 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by hub.freebsd.org (Postfix) with ESMTP id BAF7237B408 for ; Wed, 22 May 2002 10:06:09 -0700 (PDT) Received: (qmail 19999 invoked from network); 22 May 2002 17:06:08 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 22 May 2002 17:06:08 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4MH62F00460; Wed, 22 May 2002 13:06:02 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020523013305.B10069-100000@gamplex.bde.org> Date: Wed, 22 May 2002 13:05:36 -0400 (EDT) From: John Baldwin To: Bruce Evans Subject: Re: cvs commit: src/sys/i386/include cpufunc.h src/sys/kern kern Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 22-May-2002 Bruce Evans wrote: > On Wed, 22 May 2002, John Baldwin wrote: > >> jhb 2002/05/22 06:19:22 PDT >> >> Modified files: >> sys/i386/include cpufunc.h >> sys/kern kern_mutex.c >> Log: >> Rename cpu_pause() to pause(). Originally I was going to make this an >> MI API with empty cpu_pause() functions on other arch's, but this >> functionality is definitely unique to IA-32, so I decided to leave it >> as i386-only and wrap it in #ifdef's. I should have dropped the cpu_ >> prefix when I made that decision. >> >> Requested by: bde >> >> Revision Changes Path >> 1.122 +1 -1 src/sys/i386/include/cpufunc.h >> 1.96 +5 -5 src/sys/kern/kern_mutex.c > > Thanks. Er, I'm not sure that this is an improvement, since the ugly >#ifdefs are now meant to stay :-). Well, I'm not a big fan of the #ifdef's either, but I think having bogus empty cpu_pause() implementations for all our other arch's is worse.. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message