From nobody Sat Nov 4 19:25:08 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SN6yD4Fq3z50JVJ; Sat, 4 Nov 2023 19:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SN6yD3dYBz4GJK; Sat, 4 Nov 2023 19:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699125908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0qSLMmngyu/itXzcYHcsUJ0t113JrShgOkcujSO5DbY=; b=yzPbKBNjRuoixngoL5RnVvIdR5PO/hjgvlVXlKui+VcPXYJv4noCakvOGwEwUdfUZkinQl +lfiFdBVEgRfnKae78D5dNKQ31IITSIRs0EcEjUA/3kAU/17EGl9lHPDaVIoX1oBd5vG05 en0JH21A+7n4DbQGo+UTZwyRuQG346c4X4xgopSNi5x/F3ilUBg4b8ygiON9KdQz2dkhYB /i4TSxslYCqGpVl1iaZQyCgQDpxlV/f5AvDRFV+AZTyCJZ+3n3JZcLs6JIEG+8gZahWhtR DagnfeeletJlzuc1tbTvvQDtdR6GQrr1PmmW8zBSj+VqjoucOGTRKtP6WAlFmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699125908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0qSLMmngyu/itXzcYHcsUJ0t113JrShgOkcujSO5DbY=; b=qyQXrE+Jf/iUHSWZnY/BQulTMvPLYGBkWWLcsfPmbmmkiOhz6Ic/s+vD6EyClHbIz1F2KY GfAbEozKCgVDHspxdJAPaJ0g3dgz2BPJBVT1QCMmt3smPhxiJtdhHT5RwJQ9Shqa+NSWax MZa6C0pX7VmFOSsqmXegp4R7ZI+PEX6Ckb+7S6Pj/zWB3L+sL4mouBIrXE10eFjWqiuBEn siQ1zdTJ/f4JroiyCqHX6d3XLbTCBTyzR836aQkp7/ugP3bQCEBXY6aQWYtKhnwZsQ/Nmg GscyaLmFb4aHfkiFRWbrKbVOPuQXqkLPNJkKornmT47dIgzBveT4IWdtwL0dzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699125908; a=rsa-sha256; cv=none; b=ujzEzTD6yS3pG6Cqv3pzdFCD/a6L0/Yl1OiuaDcZO7ZEWJ3t3PSCVkBiIgBrDP965lf1gx U/MCpiNtSUL07T2lwdjUUgWOeVIsCK9K+Jymj/APMJYPoVuqEqWjUAsBK+7da5kLByFLpy o9inABno+AkK8ry+PH1rki/nd9RYi0g+CQupEj8qiOzlBrTODGUgayL0Sae3pW3eRRrVa2 ldMRp8XHHaGVglfz3zWEmp1k6TLvh20Uq3BUYrUnhCcv1hiDzCbvcF6IV+2pgl5Q0Y5S8C RUEzEVyhaJgcFqMDZwYMOk3BFpZnnipcaz3LFfXpTFtTX2NXwwx3LExrRX2kMQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SN6yD2h5Gz18fn; Sat, 4 Nov 2023 19:25:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3A4JP8Gg020769; Sat, 4 Nov 2023 19:25:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3A4JP8mD020766; Sat, 4 Nov 2023 19:25:08 GMT (envelope-from git) Date: Sat, 4 Nov 2023 19:25:08 GMT Message-Id: <202311041925.3A4JP8mD020766@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ka Ho Ng Subject: git: cffcdfbf4938 - stable/13 - mlx5ib: Fix RSS Toeplitz setup to be aligned with the HW specification List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: khng X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: cffcdfbf4938083c1977d645ebe78c636ab9a43f Auto-Submitted: auto-generated The branch stable/13 has been updated by khng: URL: https://cgit.FreeBSD.org/src/commit/?id=cffcdfbf4938083c1977d645ebe78c636ab9a43f commit cffcdfbf4938083c1977d645ebe78c636ab9a43f Author: Yishai Hadas AuthorDate: 2023-10-28 20:55:47 +0000 Commit: Ka Ho Ng CommitDate: 2023-11-04 19:24:36 +0000 mlx5ib: Fix RSS Toeplitz setup to be aligned with the HW specification The specification for the Toeplitz function doesn't require to set the key explicitly to be symmetric. In case a symmetric functionality is required a symmetric key can be simply used. Wrongly forcing the algorithm to symmetric causes the wrong packet distribution and a performance degradation. Link: https://lore.kernel.org/r/20190723065733.4899-7-leon@kernel.org Fixes: 28d6137008b2 ("IB/mlx5: Add RSS QP support") Signed-off-by: Yishai Hadas Reviewed-by: Alex Vainman Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe [khng: cherry-picked from Linux b7165bd0d6cbb93732559be6ea8774653b204480] Sponsored by: Juniper Networks, Inc. MFC after: 7 days Reviewed by: kib, zlei Differential Revision: https://reviews.freebsd.org/D42178 (cherry picked from commit 813d981e1e78daffde4b2a05df35d054fcb4343f) --- sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c b/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c index 7d57db8f4581..33021d1c6dd8 100644 --- a/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c +++ b/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c @@ -1426,7 +1426,6 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, } MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FUNC_TOEPLITZ); - MLX5_SET(tirc, tirc, rx_hash_symmetric, 1); memcpy(rss_key, ucmd.rx_hash_key, len); break; }