From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 27 20:30:11 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id EE05516A409
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2007 20:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id DCB5613C48C
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2007 20:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l3RKUBsB067865
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 27 Apr 2007 20:30:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l3RKUBnJ067861;
	Fri, 27 Apr 2007 20:30:11 GMT (envelope-from gnats)
Date: Fri, 27 Apr 2007 20:30:11 GMT
Message-Id: <200704272030.l3RKUBnJ067861@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Scott Long <scottl@samsco.org>
Cc: 
Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Scott Long <scottl@samsco.org>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2007 20:30:12 -0000

The following reply was made to PR kern/112119; it has been noted by GNATS.

From: Scott Long <scottl@samsco.org>
To: Thomas Quinot <thomas@FreeBSD.ORG>
Cc: Nikolay Pavlov <quetzal@zone3000.net>,
        "Ganbold.TS" <ganbold@micom.mng.net>, freebsd-stable@FreeBSD.ORG,
        mjacob@FreeBSD.ORG, linimon@FreeBSD.ORG, bug-followup@FreeBSD.ORG
Subject: Re: kern/112119: system hangs when starts k3b on RELENG_6
Date: Fri, 27 Apr 2007 14:28:14 -0600

 Thomas Quinot wrote:
 > * Scott Long, 2007-04-27 :
 > 
 >> Oh hell, I know exactly what the problem is!  The opcode for a
 >> TEST_UNIT_READY is 0x00.  This is probably the command that is
 >> generating the CHECK_CONDITION.  The test for saved_cmd is entirely
 >> bogus.
 > 
 > Hmmmm. Looks like a very plausible culprit. Good catch Scott!
 > (I felt there had to be something wrong when I wrote that test,
 > incidentally, precisely because of TEST_UNIT_READY).
 > 
 > Nikolay, Ganbold, (and others), here's another patch against 1.42.2.3,
 > please let me know if it works for you.
 > 
 > Thomas.
 > 
 > Index: atapi-cam.c
 > ===================================================================
 > RCS file: /space/mirror/ncvs/src/sys/dev/ata/atapi-cam.c,v
 > retrieving revision 1.50
 > diff -u -r1.50 atapi-cam.c
 > --- atapi-cam.c	14 Mar 2007 01:59:00 -0000	1.50
 > +++ atapi-cam.c	27 Apr 2007 19:26:09 -0000
 > @@ -729,7 +743,7 @@
 >  		 * issued a REQUEST SENSE automatically and that operation
 >  		 * returned without error.
 >  		 */
 > -		if (request->u.atapi.saved_cmd != 0 && request->error == 0) {
 > +		if (request->u.atapi.sense.key != 0 && request->error == 0) {
 >  		    bcopy (&request->u.atapi.sense, &csio->sense_data, sizeof(struct atapi_sense));
 >  		    csio->ccb_h.status |= CAM_AUTOSNS_VALID;
 >  		}
 
 Right, just make sure that this isn't filled with garbage before you
 send the command.  If you're using ata_alloc_request(), and you're not
 recycling requests internally, then you should be fine.
 
 Scott