From owner-svn-src-all@freebsd.org Wed May 22 15:48:14 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 731E115AF1CB; Wed, 22 May 2019 15:48:14 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC93F8BB58; Wed, 22 May 2019 15:48:13 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x4MFmAZH085474; Wed, 22 May 2019 08:48:10 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x4MFmAIF085473; Wed, 22 May 2019 08:48:10 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905221548.x4MFmAIF085473@gndrsh.dnsmgr.net> Subject: Re: svn commit: r348090 - in head/libexec/bootpd: . bootpgw In-Reply-To: <20190522151116.GB5125@spy> To: Mark Johnston Date: Wed, 22 May 2019 08:48:10 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: CC93F8BB58 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 15:48:14 -0000 > On Tue, May 21, 2019 at 09:25:23PM -0700, Rodney W. Grimes wrote: > > > Author: markj > > > Date: Wed May 22 04:13:57 2019 > > > New Revision: 348090 > > > URL: https://svnweb.freebsd.org/changeset/base/348090 > > > > > > Log: > > > Marginally improve usage() message style in bootpd. > > > > > > - Remove an extra space after "usage:". > > > - Avoid lines exceeding 80 columns. > > > > > > Based on notes from rgrimes. > > > > Thanks, but you missed an important aspect of those notes, > > see inline below. > > > > > > > > MFC with: r348066 > > > Event: Waterloo Hackathon 2019 > > > > > > Modified: > > > head/libexec/bootpd/bootpd.c > > > head/libexec/bootpd/bootpgw/bootpgw.c > > > > > > Modified: head/libexec/bootpd/bootpd.c > > > ============================================================================== > > > --- head/libexec/bootpd/bootpd.c Wed May 22 04:10:24 2019 (r348089) > > > +++ head/libexec/bootpd/bootpd.c Wed May 22 04:13:57 2019 (r348090) > > > @@ -587,8 +587,8 @@ PRIVATE void > > > usage() > > > { > > > fprintf(stderr, > > > - "usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h hostname] [-t timeout]\n"); > > > - fprintf(stderr, " [bootptab [dumpfile]]\n"); > > > + "usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h hostname]\n" > > > + " [-t timeout] [bootptab [dumpfile]]\n"); > > > fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > > > fprintf(stderr, "\t -c n\tset current directory\n"); > > > fprintf(stderr, "\t -d n\tset debug level\n"); > > > > These 3 printf's are now miss aligned and contain a \t that should not be there: > > there may be more, I am only look at what is in context here. > > - fprintf(stderr, "\t -a\tdon't modify ARP table\n"); > > - fprintf(stderr, "\t -c n\tset current directory\n"); > > - fprintf(stderr, "\t -d n\tset debug level\n"); > > + fprintf(stderr, " -a\tdon't modify ARP table\n"); > > + fprintf(stderr, " -c n\tset current directory\n"); > > + fprintf(stderr, " -d n\tset debug level\n"); > > They were seemingly misaligned before too. > > Before: > usage: bootpd [-i | -s] [-c chdir-path] [-d level] [-h hostname] [-t timeout] > [bootptab [dumpfile]] > -c n set current directory > -d n set debug level > -h n set the hostname to listen on > -i force inetd mode (run as child of inetd) > -s force standalone mode (run without inetd) > -t n set inetd exit timeout to n minutes > > After: > usage: bootpd [-a] [-i | -s] [-c chdir-path] [-d level] [-h hostname] > [-t timeout] [bootptab [dumpfile]] > -a don't modify ARP table > -c n set current directory > -d n set debug level > -h n set the hostname to listen on > -i force inetd mode (run as child of inetd) > -s force standalone mode (run without inetd) > -t n set inetd exit timeout to n minutes > > To be honest I have no desire to spend more time on bootpd than I > already have. You are welcome to improve the usage formatting if > you like. omg, really? Old "folke lore" You touched, you own it. If I didnt have to go through bde and/or phk I would of just gone and commited the clean up. I have handed you the diff. Perhaps a phab review before would of made this less painfull. And perhaps a phab review once an issue had been raised would of been really less painful. -- Rod Grimes rgrimes@freebsd.org