Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 May 2023 04:56:57 GMT
From:      Enji Cooper <ngie@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 9a49a3792940 - main - mptutil: document that disabled/enabled are also supported
Message-ID:  <202305250456.34P4uvQl022770@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by ngie:

URL: https://cgit.FreeBSD.org/src/commit/?id=9a49a3792940497ddf4657f6e5be56d8ef881edc

commit 9a49a3792940497ddf4657f6e5be56d8ef881edc
Author:     Enji Cooper <ngie@FreeBSD.org>
AuthorDate: 2023-05-25 04:54:02 +0000
Commit:     Enji Cooper <ngie@FreeBSD.org>
CommitDate: 2023-05-25 04:56:42 +0000

    mptutil: document that disabled/enabled are also supported
    
    This change officially documents the fact that the `volume cache
    enabled` and `volume cache disabled` are also supported.
    
    While here, remove an unnecessary newline at the end of a warn*(3) call.
    warn*(3) adds a newline automatically.
    
    MFC after:      1 week
---
 usr.sbin/mptutil/mpt_volume.c | 3 ++-
 usr.sbin/mptutil/mptutil.8    | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/usr.sbin/mptutil/mpt_volume.c b/usr.sbin/mptutil/mpt_volume.c
index 04f69bcdf929..ddf6492a8592 100644
--- a/usr.sbin/mptutil/mpt_volume.c
+++ b/usr.sbin/mptutil/mpt_volume.c
@@ -219,7 +219,8 @@ volume_cache(int ac, char **av)
                 *s1 = tolower(*s1);
 	if ((strcmp(av[2], "enable")) && (strcmp(av[2], "enabled")) &&
 	    (strcmp(av[2], "disable")) && (strcmp(av[2], "disabled"))) {
-		warnx("volume cache: invalid flag, must be 'enable' or 'disable'\n");
+		warnx("volume cache: invalid flag; "
+		    "must be 'enable', 'enabled', 'disable', or 'disabled'");
 		return (EINVAL);
 	}
 
diff --git a/usr.sbin/mptutil/mptutil.8 b/usr.sbin/mptutil/mptutil.8
index e8b617ffbcaf..2059bc994849 100644
--- a/usr.sbin/mptutil/mptutil.8
+++ b/usr.sbin/mptutil/mptutil.8
@@ -29,7 +29,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd August 16, 2009
+.Dd May 24, 2024
 .Dt MPTUTIL 8
 .Os
 .Sh NAME
@@ -71,7 +71,7 @@
 .Nm
 .Op Fl u Ar unit
 .Cm volume cache Ar volume
-.Ar enable|disable
+.Ar enable|enabled|disable|disabled
 .Nm
 .Op Fl u Ar unit
 .Cm clear
@@ -239,7 +239,7 @@ Sets the name of
 .Ar volume
 to
 .Ar name .
-.It Cm volume cache Ar volume Ar enable|disable
+.It Cm volume cache Ar volume Ar enable|enabled|disable|disabled
 Enables or disables the drive write cache for the member drives of
 .Ar volume .
 .It Cm volume status Ar volume



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202305250456.34P4uvQl022770>