From owner-svn-src-all@FreeBSD.ORG Thu Oct 28 00:52:36 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD07B106564A; Thu, 28 Oct 2010 00:52:36 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 75B588FC08; Thu, 28 Oct 2010 00:52:35 +0000 (UTC) Received: by wwi17 with SMTP id 17so111023wwi.31 for ; Wed, 27 Oct 2010 17:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=7HYUvgh5gmoLReYbkeJxykoBuCU9Oac891nYJXN6dXQ=; b=b25K0hYbb2L+sb0E5qnMIqs19Q0BgJx7XdoQ6WEg7N530cdiYCgzPUcw8l172cop/4 Kc2tqdbe5lB8Md3nOsFqSWV/8hRr33PVfWm9l4HCb1eRL5pjoSW7Uzk4SM1HCcfCrng7 zFeI1aewMxx+t72LaG1g2ZHYDH/fQCUgsu7Nw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=Qu5qMYjHhYnBSJjIOZoyMm8rwFsXGtVcqAPsZ9PgyRrzRxxXE4Btd8NJRMChsv5rQE RT1iWW5ynd2ukK3YNEfhdvcSdJrmdlzsAQZZyhcXwOCxDzgYTVDS9blnkv+7lGYnzkux 1H3YFqDl7Grxj4ZnI+uh9RB3R9yC/Yfy9tMd4= MIME-Version: 1.0 Received: by 10.216.11.205 with SMTP id 55mr9833917wex.51.1288227154317; Wed, 27 Oct 2010 17:52:34 -0700 (PDT) Sender: yanegomi@gmail.com Received: by 10.216.10.198 with HTTP; Wed, 27 Oct 2010 17:52:34 -0700 (PDT) In-Reply-To: <4CC851CC.80509@freebsd.org> References: <201010270232.o9R2Wsu3084553@svn.freebsd.org> <4CC803A8.3040602@freebsd.org> <20101027082122.GD1848@garage.freebsd.pl> <4CC85552.2020100@freebsd.org> <20101027133307.GQ2392@deviant.kiev.zoral.com.ua> <4CC851CC.80509@freebsd.org> Date: Wed, 27 Oct 2010 17:52:34 -0700 X-Google-Sender-Auth: g5uen7lMADsl5cItc3H3YgFSqbQ Message-ID: From: Garrett Cooper To: Andriy Gapon Content-Type: multipart/mixed; boundary=0016364d2cbdec533f0493a2c1cf Cc: src-committers@freebsd.org, Pawel Jakub Dawidek , svn-src-all@freebsd.org, svn-src-head@freebsd.org, David Xu , Kostik Belousov Subject: Re: svn commit: r214409 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Oct 2010 00:52:36 -0000 --0016364d2cbdec533f0493a2c1cf Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2010 at 9:22 AM, Andriy Gapon wrote: > > [patch attachment was lost] Ugh... Mailman hates me I guess :(... > on 27/10/2010 19:07 Garrett Cooper said the following: >> =A0 =A0 How about this patch? I implemented this as a readonly tunable a= nd > > I don't think that it's correct to call it a tunable or use CTLFLAG_RDTUN= . > As I understand it is a read-only sysctl. Converted to CTLFLAG_RD. >> sysconf tunable, because (AFAIK) the value that is being tested >> shouldn't change during runtime after the system has been booted up, >> and figuring that the value wasn't going to change it was better to >> lose 4/8 bytes on the kernel stack instead of having to recompute the >> value every time in a function call, with the associated lost heap / >> stack memory in the process, as the assumption is that this libcall >> was going to be called frequently by some programs. Thanks! -Garrett --0016364d2cbdec533f0493a2c1cf Content-Type: text/x-patch; charset=US-ASCII; name="cpuset_t-size-sysctl-and-sysconf-value.patch" Content-Disposition: attachment; filename="cpuset_t-size-sysctl-and-sysconf-value.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gfsx6dxs0 SW5kZXg6IGluY2x1ZGUvdW5pc3RkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaW5jbHVkZS91bmlzdGQuaAko cmV2aXNpb24gMjE0NDEzKQorKysgaW5jbHVkZS91bmlzdGQuaAkod29ya2luZyBjb3B5KQpAQCAt Mjg4LDYgKzI4OCw3IEBACiAjaWYgX19CU0RfVklTSUJMRQogI2RlZmluZQlfU0NfTlBST0NFU1NP UlNfQ09ORgk1NwogI2RlZmluZQlfU0NfTlBST0NFU1NPUlNfT05MTgk1OAorI2RlZmluZQlfU0Nf Q1BVU0VUX1NJWkUJCTEyMgogI2VuZGlmCiAKIC8qIEV4dGVuc2lvbnMgZm91bmQgaW4gU29sYXJp cyBhbmQgTGludXguICovCkluZGV4OiBsaWIvbGliYy9nZW4vc3lzY29uZi5jCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGxpYi9saWJjL2dlbi9zeXNjb25mLmMJKHJldmlzaW9uIDIxNDQxMykKKysrIGxpYi9saWJj L2dlbi9zeXNjb25mLmMJKHdvcmtpbmcgY29weSkKQEAgLTU5Nyw2ICs1OTcsMTUgQEAKIAkJcmV0 dXJuIChsdmFsdWUpOwogI2VuZGlmCiAKKyNpZmRlZiBfU0NfQ1BVU0VUX1NJWkUKKwljYXNlIF9T Q19DUFVTRVRfU0laRToKKwkJbGVuID0gc2l6ZW9mKGx2YWx1ZSk7CisJCWlmIChzeXNjdGxieW5h bWUoImtlcm4uc2NoZWQuY3B1c2V0c2l6ZSIsICZsdmFsdWUsICZsZW4sIE5VTEwsCisJCSAgICAw KSA9PSAtMSkKKwkJCXJldHVybiAoLTEpOworCQlyZXR1cm4gKGx2YWx1ZSk7CisjZW5kaWYKKwog CWRlZmF1bHQ6CiAJCWVycm5vID0gRUlOVkFMOwogCQlyZXR1cm4gKC0xKTsKSW5kZXg6IHN5cy9r ZXJuL3NjaGVkX3VsZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9rZXJuL3NjaGVkX3VsZS5jCShyZXZp c2lvbiAyMTQ0MTMpCisrKyBzeXMva2Vybi9zY2hlZF91bGUuYwkod29ya2luZyBjb3B5KQpAQCAt MjcxMiw2ICsyNzEyLDggQEAKIAlzYnVmX2RlbGV0ZSh0b3BvKTsKIAlyZXR1cm4gKGVycik7CiB9 CisKK3N0YXRpYyBzaXplX3QgX2tlcm5fY3B1c2V0X3NpemUgPSBzaXplb2YoY3B1c2V0X3QpOwog I2VuZGlmCiAKIFNZU0NUTF9OT0RFKF9rZXJuLCBPSURfQVVUTywgc2NoZWQsIENUTEZMQUdfUlcs IDAsICJTY2hlZHVsZXIiKTsKQEAgLTI3NDgsNiArMjc1MCwxNSBAQAogU1lTQ1RMX1BST0MoX2tl cm5fc2NoZWQsIE9JRF9BVVRPLCB0b3BvbG9neV9zcGVjLCBDVExUWVBFX1NUUklORyB8CiAgICAg Q1RMRkxBR19SRCwgTlVMTCwgMCwgc3lzY3RsX2tlcm5fc2NoZWRfdG9wb2xvZ3lfc3BlYywgIkEi LCAKICAgICAiWE1MIGR1bXAgb2YgZGV0ZWN0ZWQgQ1BVIHRvcG9sb2d5Iik7CisKKy8qIAorICog UmV0dXJuIHRoZSBzaXplIG9mIGNwdXNldF90IGF0IHRoZSBrZXJuZWwgbGV2ZWwKKyAqCisgKiBY WFggKGdjb29wZXIpOiByZXBsYWNlIFVMT05HIHdpdGggU0laRSBvbmNlIENUTFRZUEVfU0laRSBp cyBpbXBsZW1lbnRlZC4KKyAqLworU1lTQ1RMX1VMT05HKF9rZXJuX3NjaGVkLCBPSURfQVVUTywg Y3B1c2V0c2l6ZSwgQ1RMRkxBR19SRCwKKyAgICAmX2tlcm5fY3B1c2V0X3NpemUsIDAsICJLZXJu ZWwtbGV2ZWwgY3B1c2V0X3Qgc3RydWN0IHNpemUiKTsKKwogI2VuZGlmCiAKIC8qIHBzIGNvbXBh dC4gIEFsbCBjcHUgcGVyY2VudGFnZXMgZnJvbSBVTEUgYXJlIHdlaWdodGVkLiAqLwo= --0016364d2cbdec533f0493a2c1cf--