From owner-cvs-all@FreeBSD.ORG Wed Sep 13 23:58:12 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5534F16A407; Wed, 13 Sep 2006 23:58:12 +0000 (UTC) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB9D843D46; Wed, 13 Sep 2006 23:58:11 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.NUXI.org (obrien@localhost [127.0.0.1]) by dragon.NUXI.org (8.13.7/8.13.7) with ESMTP id k8DNwARq088652; Wed, 13 Sep 2006 16:58:11 -0700 (PDT) (envelope-from obrien@dragon.NUXI.org) Received: (from obrien@localhost) by dragon.NUXI.org (8.13.7/8.13.7/Submit) id k8DNwA7b088651; Wed, 13 Sep 2006 16:58:10 -0700 (PDT) (envelope-from obrien) Date: Wed, 13 Sep 2006 16:58:10 -0700 From: "David O'Brien" To: Juli Mallett Message-ID: <20060913235810.GA87164@dragon.NUXI.org> References: <200609132327.k8DNRMqS076204@repoman.freebsd.org> <20060913233211.GA83839@toxic.magnesium.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060913233211.GA83839@toxic.magnesium.net> X-Operating-System: FreeBSD 7.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 User-Agent: Mutt/1.5.11 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2006 23:58:12 -0000 On Wed, Sep 13, 2006 at 01:32:11PM -1000, Juli Mallett wrote: > [ cvs commit: src/share/mk bsd.lib.mk bsd.prog.mk ] > > When building WITHOUT_ASSERT_DEBUG, we need to disable -Werror as its easy > > to see "warning: unused variable `foo'". > > I think it might be a better idea to -Wno-unused, since the only sorts of > warnings one wants to ignore building NDEBUG are the variables which are > otherwise unused. Hum.. I assumed that WITHOUT_ASSERT_DEBUG was a rare case and used as part of producing a production release where one knows /usr/src builds as-usual. -Wno-unused would scratch this itch, but we need to find a way to codify it so that we're not putting GCC options into share/mk. I guess make a NO_WUNUSED knob. -- -- David (obrien@FreeBSD.org)