Date: Sun, 27 Aug 2006 08:07:14 -0600 From: Scott Long <scottl@samsco.org> To: Danny Braniss <danny@cs.huji.ac.il> Cc: "Kenneth D. Merry" <ken@freebsd.org>, scsi@freebsd.org Subject: Re: iSCSI/luns/check-condition Message-ID: <44F1A712.40609@samsco.org> In-Reply-To: <E1GHLEd-000EHG-UC@cs1.cs.huji.ac.il> References: <E1GHKp2-000Dcf-FQ@cs1.cs.huji.ac.il> <E1GHLEd-000EHG-UC@cs1.cs.huji.ac.il>
next in thread | previous in thread | raw e-mail | index | archive | help
Danny Braniss wrote: > i guess what this just proves, yet again, that programs work, > even if the programmer was _____ (fill in the blanks) > > ... > >> ccb_h->status |= CAM_AUTOSNS_VALID; <---------------------- >> >>and >>... >> case 0x02: // Check Condition >> if(pq != NULL) // XXX: check for data ... >> getSenseData(status, ccb, pq); >> >> case 0x14: // Intermediate-Condition Met >> case 0x10: // Intermediate >> case 0x04: // Condition Met >> ccb_h->status = CAM_REQ_CMP_ERR; //CAM_SCSI_STATUS_ERROR; <-------------- >> break; >>... >> > > > danny > > Good catch. That is a common mistake when dealing with CAM =-) Arguably, cam_periph_error() shouldn't be so fragile and prone to loops. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44F1A712.40609>